chore(deps): replace custom bcp47_strict_language_tag with upstream#356
Merged
bfabio merged 1 commit intoitalia:mainfrom Apr 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 84.76% 84.09% -0.68%
==========================================
Files 15 14 -1
Lines 1201 1100 -101
==========================================
- Hits 1018 925 -93
+ Misses 155 151 -4
+ Partials 28 24 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
go-playground/validator@b599053 added bcp47_strict_language_tag as a built-in validator (go-playground/validator#1489), so our copy is now redundant. Drop validators/bcp47.go and its tests; update bcp47_keys to delegate to the built-in tag via a package-level Validate instance. Closes italia#341, closes italia#342.
creed-bratton
force-pushed
the
bcp47-upstream-validator
branch
from
b872dda to
08462a2
Compare
bfabio
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-playground/validator#1489 added
bcp47_strict_language_tagas a built-in validator. Our copy invalidators/bcp47.go(~400 lines including IANA data tables) is now redundant.validators/bcp47.goand its test filebcp47_keysto delegate to the built-in tag via a package-levelValidateinstancego-playground/validator/v10to the post-merge commit (b599053) ahead of the next releaseCloses #341, closes #342.