Conversation
v1 dropped the whole Italian country section, so IT and it are now unknown fields. Moved the conforme, riuso/codiceIPA and lowercase section fixtures into the invalid v1 set.
phone numvers is now validated as E.164.
government is no longer a valid intendedAudience scope in v1.
v1 country codes must be strict ISO 3166-1 alpha-2, uppercase only.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 83.80% 83.07% -0.74%
==========================================
Files 14 15 +1
Lines 1099 1087 -12
==========================================
- Hits 921 903 -18
- Misses 154 160 +6
Partials 24 24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publiccode.yml 1.0 is in RC and the parser needs to handle the new
major version.
This adds v1 parsing and aligns validation with the 1.0-rc spec:
IT:is now an unknown fieldphonemust follow E.164governmentis no longer a valid scopeDraft because 1.0 is still an RC and can change, so let's not merge
until it's final.