Skip to content

Commit 8b4251b

Browse files
committed
refactor: use bytes.NewReader() and fix linting issues
1 parent 87de00f commit 8b4251b

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

internal/handlers/validate.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
package handlers
22

33
import (
4+
"bytes"
45
"errors"
5-
"fmt"
6-
"strings"
76

87
"github.com/gofiber/fiber/v2"
98
publiccodeParser "github.com/italia/publiccode-parser-go/v5"
@@ -16,7 +15,7 @@ type PubliccodeymlValidatorHandler struct {
1615
func NewPubliccodeymlValidatorHandler() *PubliccodeymlValidatorHandler {
1716
parser, err := publiccodeParser.NewDefaultParser()
1817
if err != nil {
19-
panic(fmt.Sprintf("can't create a publiccode.yml parser: %s", err.Error()))
18+
panic("can't create a publiccode.yml parser: " + err.Error())
2019
}
2120

2221
return &PubliccodeymlValidatorHandler{parser: parser}
@@ -42,10 +41,7 @@ func (vh *PubliccodeymlValidatorHandler) Query(ctx *fiber.Ctx) error {
4241
})
4342
}
4443

45-
// Body() ritorna []byte; lo wrappiamo in io.Reader
46-
reader := strings.NewReader(string(ctx.Body()))
47-
// alternativa più efficiente:
48-
// reader := bytes.NewReader(c.Body())
44+
reader := bytes.NewReader(ctx.Body())
4945

5046
// parsed, err = parser.Parse(repository.FileRawURL)
5147
_, err := vh.parser.ParseStream(reader)

main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ func Setup() *fiber.App {
6565
func setupHandlers(app *fiber.App) {
6666
validateHandler := handlers.NewPubliccodeymlValidatorHandler()
6767

68-
//nolint:varnamelen
6968
v1 := app.Group("/v1")
7069

7170
v1.Add("QUERY", "/validate", validateHandler.Query)

0 commit comments

Comments
 (0)