fix: move @oxlint/plugins from peerDependency to dependency (#102)#107
Conversation
📝 WalkthroughWalkthrough
ChangesDependency Reclassification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
60-62: ⚖️ Poor tradeoffAlign
@oxlint/pluginsdependency type with Oxlint plugin guidance
- Oxlint docs recommend publishing plugins with
@oxlint/pluginsas a runtime dependency (not a dev dependency) becauseeslintCompatPluginmust be present when the consumer executes the plugin.- Other published oxlint plugins already declare
@oxlint/pluginsunderdependencies(e.g.,@mkaradeniz/oxlint-plugin-whitespace,oxlint-plugin-effect), matching this change.- Still consider validating that having multiple
@oxlint/pluginsversions/copies in a consumer install won’t cause any issues (since each plugin can bring its own range).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 60 - 62, The package currently lists "`@oxlint/plugins`" incorrectly (should be a runtime dependency) — update package.json so "`@oxlint/plugins`" is moved from devDependencies to dependencies with the same version range (e.g., "^1.62.0") so eslintCompatPlugin is available at consumer runtime; after changing, run an install/test to confirm the package still builds and validate that multiple copies/versions of "`@oxlint/plugins`" in a consumer environment do not cause conflicts (check resolution tree / hoisting behavior) to ensure compatibility.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Around line 60-62: The package currently lists "`@oxlint/plugins`" incorrectly
(should be a runtime dependency) — update package.json so "`@oxlint/plugins`" is
moved from devDependencies to dependencies with the same version range (e.g.,
"^1.62.0") so eslintCompatPlugin is available at consumer runtime; after
changing, run an install/test to confirm the package still builds and validate
that multiple copies/versions of "`@oxlint/plugins`" in a consumer environment do
not cause conflicts (check resolution tree / hoisting behavior) to ensure
compatibility.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bd1817b3-fbbc-4fb6-9bf5-a37a4b28b1ba
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
Summary by CodeRabbit
@oxlint/pluginsis now a runtime dependency, automatically included with installationdiff,estree-walker, andoxc-parseronly, reducing setup complexity