Skip to content

Do not reset tabline or statusline if they are not used - #691

Open
danhorner wants to merge 2 commits into
itchyny:masterfrom
danhorner:main
Open

Do not reset tabline or statusline if they are not used#691
danhorner wants to merge 2 commits into
itchyny:masterfrom
danhorner:main

Conversation

@danhorner

Copy link
Copy Markdown

Hi.

Resubmitting #690 with new a testcase. The first commit adds a new testcase demonstrating the issue from #687. The second commit resolves updates lightline to resolve it.

Problem overview:

  1. Plugin manager loads lightline. My config disables tabline with g:lightline.enable.tabline==0. Lightline saves &tabline anyway
  2. Plugin manager loads a different tabline plugin which customizes &tabline
  3. Calling lightline#disable() restores the (wrong) saved tabline

Thanks again for your work.

 - Save tabline and statusline during activation only when lightline will
   overwrite them
 - Restore saved tabline and statusline during deactivation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant