Allow use of filter with ids in external search#146
Merged
cigolpl merged 1 commit intoitemsapi:masterfrom Nov 20, 2025
Merged
Conversation
Member
|
Hey, thanks. You can update now itemsjs from npmjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
I was implementing the external full text search with Lunr and noticed it wasn't possible to use the
filteroption.I am using the
filteroption to make range searches like prices and would need it added to the text search.Here is my proposed improvement to be able to use the external text search in addition to any search function in the
filteroption.I added a test to illustrate the use case.
Thank you for your consideration.