Don't layout absolutely positioned wrappers in other absolutely positioned wrappers

Author: GrimySoal

layout/src/main/java/com/itextpdf/layout/properties/Property.java

@@ -243,14 +243,15 @@ public final class Property {
     public static final int TOP_CALCULATED = 162;
     public static final int LEFT_CALCULATED = 163;
     public static final int POSITIONED_ELEMENT_WRAPPED = 164;
+    public static final int POSITIONED_ELEMENT_WRAPPER_LAYOUT = 165;
 
     /**
      * Some properties must be passed to {@link IPropertyContainer} objects that
      * are lower in the document's hierarchy. Most inherited properties are
      * related to textual operations. Indicates whether this type of property is inheritable.
      */
     private static final boolean[] INHERITED_PROPERTIES;
-    private static final int MAX_INHERITED_PROPERTY_ID = 161;
+    private static final int MAX_INHERITED_PROPERTY_ID = 165;
 
     static {
         INHERITED_PROPERTIES = new boolean[MAX_INHERITED_PROPERTY_ID + 1];
@@ -301,6 +302,7 @@ public final class Property {
         INHERITED_PROPERTIES[Property.ADD_MARKED_CONTENT_TEXT] = true;
         INHERITED_PROPERTIES[Property.TREAT_AS_CONTINUOUS_CONTAINER] = true;
         INHERITED_PROPERTIES[Property.IGNORE_AREA_AND_SECTION_BREAKS] = true;
+        INHERITED_PROPERTIES[Property.POSITIONED_ELEMENT_WRAPPER_LAYOUT] = true;
     }
 
     private Property() {

layout/src/main/java/com/itextpdf/layout/renderer/AbsolutelyPositionedRenderer.java

@@ -57,9 +57,13 @@ public AbsolutelyPositionedRenderer(IRenderer wrappedRenderer, boolean verticalC
     @Override
     public LayoutResult layout(LayoutContext layoutContext) {
         LayoutContext copiedContext = copyContext(layoutContext);
+        if (wrappedRenderer.hasProperty(Property.POSITIONED_ELEMENT_WRAPPER_LAYOUT)) {
+            return dummyRenderer.layout(copiedContext);
+        }
         Object positioning = wrappedRenderer.<Integer>getOwnProperty(Property.POSITION);
         wrappedRenderer.setProperty(Property.POSITION, LayoutPosition.STATIC);
         wrappedRenderer.setProperty(Property.FLOAT, FloatPropertyValue.NONE);
+        wrappedRenderer.setProperty(Property.POSITIONED_ELEMENT_WRAPPER_LAYOUT, new Object());
         LayoutResult result = wrappedRenderer.layout(copiedContext);
         if (result.getStatus() == LayoutResult.NOTHING) {
             wrappedRenderer.setProperty(Property.FORCED_PLACEMENT, true);
@@ -71,6 +75,7 @@ public LayoutResult layout(LayoutContext layoutContext) {
         } else {
             wrappedRenderer.setProperty(Property.POSITION, positioning);
         }
+        wrappedRenderer.deleteOwnProperty(Property.POSITIONED_ELEMENT_WRAPPER_LAYOUT);
         if (verticalCoordinateMissing) {
             wrappedRenderer.setProperty(Property.TOP_CALCULATED, result.getOccupiedArea().getBBox().getTop());
         }
@@ -87,6 +92,26 @@ public IRenderer getWrappedRenderer() {
         return wrappedRenderer;
     }
 
+    @Override
+    public <T1> T1 getProperty(int property, T1 defaultValue) {
+        if (Property.POSITION == property) {
+            // This absolutely positioned renderer wrapper is never supposed to be treated as absolutely positioned.
+            // The whole idea of this wrapper is to calculate it's potential static coordinates.
+            return (T1) (Object) LayoutPosition.STATIC;
+        }
+        return wrappedRenderer.<T1>getProperty(property, defaultValue);
+    }
+
+    @Override
+    public <T1> T1 getProperty(int property) {
+        if (Property.POSITION == property) {
+            // This absolutely positioned renderer wrapper is never supposed to be treated as absolutely positioned.
+            // The whole idea of this wrapper is to calculate it's potential static coordinates.
+            return (T1) (Object) LayoutPosition.STATIC;
+        }
+        return wrappedRenderer.<T1>getProperty(property);
+    }
+
     @Override
     public IRenderer getNextRenderer() {
         return new AbsolutelyPositionedRenderer(wrappedRenderer.getNextRenderer(),
@@ -118,26 +143,6 @@ public boolean hasOwnProperty(int property) {
         return wrappedRenderer.hasOwnProperty(property);
     }
 
-    @Override
-    public <T1> T1 getProperty(int property) {
-        if (Property.POSITION == property) {
-            // This absolutely positioned renderer wrapper is never supposed to be treated as absolutely positioned.
-            // The whole idea of this wrapper is to calculate it's potential static coordinates.
-            return (T1) (Object) LayoutPosition.STATIC;
-        }
-        return wrappedRenderer.<T1>getProperty(property);
-    }
-
-    @Override
-    public <T1> T1 getProperty(int property, T1 defaultValue) {
-        if (Property.POSITION == property) {
-            // This absolutely positioned renderer wrapper is never supposed to be treated as absolutely positioned.
-            // The whole idea of this wrapper is to calculate it's potential static coordinates.
-            return (T1) (Object) LayoutPosition.STATIC;
-        }
-        return wrappedRenderer.<T1>getProperty(property, defaultValue);
-    }
-
     @Override
     public <T1> T1 getOwnProperty(int property) {
         return wrappedRenderer.<T1>getOwnProperty(property);

layout/src/test/java/com/itextpdf/layout/renderer/AbsolutelyPositionedRendererUnitTest.java

@@ -67,6 +67,15 @@ public void getPropertyTest() {
         Assertions.assertEquals(50, absolutelyPositionedRenderer.<Integer>getProperty(Property.LEFT));
     }
 
+    @Test
+    public void getPropertyDefaultValueTest() {
+        DivRenderer wrappedRenderer = new DivRenderer(new Div());
+        AbsolutelyPositionedRenderer absolutelyPositionedRenderer = new AbsolutelyPositionedRenderer(wrappedRenderer, false, false);
+
+        Assertions.assertEquals(LayoutPosition.STATIC, absolutelyPositionedRenderer.<Integer>getProperty(Property.POSITION, LayoutPosition.FIXED));
+        Assertions.assertEquals(50, absolutelyPositionedRenderer.<Integer>getProperty(Property.LEFT, 50));
+    }
+
     static class CustomRenderer extends DivRenderer {
         public int counter = 0;