chore: prepare 2.1.0

Author: evilebottnawi

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org).
 
+## 2.1.0 - 2018-04-26
+
+* Feature: support options for commands.
+* Fix: don't crash when `bail: true` in sync event.
+
 ## 2.0.1 - 2018-04-19
 
 * Fix: don't crash when argument is empty (string/array/object).

README.md

@@ -27,14 +27,19 @@ module.exports = {
       onBeforeRun: [
         {
           args: ["build"],
-          cmd: "del"
+          cmd: "del",
+          options: {
+            cwd: process.cwd()
+          }
         }
       ]
     })
   ]
 };
 ```
 
+Note: [list of command options](https://github.com/sindresorhus/execa#options).
+
 ## Options
 
 |         Name          |    Type     |         Default         | Description                                                                                                                                   |

__tests__/index.test.js

@@ -46,14 +46,15 @@ function mkdirSyncSafe(dir) {
 
 function unlinkSyncSafe(dir) {
   try {
-    fs.unlinkSync(dir);
+    fs.rmdirSync(dir);
   } catch (ignoreError) {
     // Nothing
   }
 }
 
 describe("execa-webpack-plugin", () => {
   const dir = path.join(__dirname, "dir");
+  const nestedDir = path.join(dir, "nested");
   const otherDir = path.join(__dirname, "other-dir");
 
   it("should throw error on `on*` options are empty (no events)", () =>
@@ -755,4 +756,60 @@ describe("execa-webpack-plugin", () => {
         return Promise.resolve();
       });
   });
+
+  it("should works with options (sync event)", () => {
+    expect.assertions(3);
+
+    mkdirSyncSafe(dir);
+    mkdirSyncSafe(nestedDir);
+
+    expect(fs.statSync(dir).isDirectory()).toBe(true);
+    expect(fs.statSync(nestedDir).isDirectory()).toBe(true);
+
+    return run({
+      onCompile: [
+        {
+          args: [nestedDir],
+          cmd: "del",
+          options: {
+            cwd: dir
+          }
+        }
+      ]
+    }).then(() => {
+      expect(() => fs.statSync(nestedDir)).toThrow();
+
+      unlinkSyncSafe(dir);
+
+      return Promise.resolve();
+    });
+  });
+
+  it("should works with options (async event)", () => {
+    expect.assertions(3);
+
+    mkdirSyncSafe(dir);
+    mkdirSyncSafe(nestedDir);
+
+    expect(fs.statSync(dir).isDirectory()).toBe(true);
+    expect(fs.statSync(nestedDir).isDirectory()).toBe(true);
+
+    return run({
+      onDone: [
+        {
+          args: [nestedDir],
+          cmd: "del",
+          options: {
+            cwd: dir
+          }
+        }
+      ]
+    }).then(() => {
+      expect(() => fs.statSync(nestedDir)).toThrow();
+
+      unlinkSyncSafe(dir);
+
+      return Promise.resolve();
+    });
+  });
 });

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "execa-webpack-plugin",
-  "version": "2.0.1",
+  "version": "2.1.0",
   "description": "A better `child_process` for `webpack`",
   "keywords": [
     "exec",

package.json

@@ -47,16 +47,16 @@ class CommandRunner {
   }
 
   run(command, async) {
-    const { cmd, args = [], opts = {} } = command;
+    const { cmd, args = [], options = {} } = command;
 
-    opts.stdio = ["ignore", "pipe", "pipe"];
+    options.stdio = ["ignore", "pipe", "pipe"];
 
     this.log.info(
       `Run command "${cmd}${args.length > 0 ? ` ${args.join(" ")}` : ""}"`
     );
 
     if (async) {
-      return execa(cmd, args, opts)
+      return execa(cmd, args, options)
         .then(asyncResult => {
           this.handleResult(asyncResult);
 
@@ -70,7 +70,7 @@ class CommandRunner {
     let result = null;
 
     try {
-      result = execa.sync(cmd, args, opts);
+      result = execa.sync(cmd, args, options);
     } catch (error) {
       this.handleError(error, command);
     }

src/CommandRunner.js

@@ -61,7 +61,7 @@ class ExecaWebpackPlugin {
 
   execute(commands, async) {
     const results = [];
-    const runCommandRunner = command => {
+    const runCommand = command => {
       if (async) {
         return Promise.all(command.args).then(resolvedArgs => {
           command.args = resolvedArgs.map(
@@ -96,7 +96,7 @@ class ExecaWebpackPlugin {
         command.args = [];
       }
 
-      results.push(runCommandRunner(command));
+      results.push(runCommand(command));
     });
 
     return async ? Promise.all(results) : results;