feat: run onBuildEnd and onBuildExit in async mode for webpack@4

Author: evilebottnawi

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org).
 
+## Head
+
+* Feature: run `onBuildEnd` and `onBuildExit` in async mode for `webpack@4`.
+
 ## 1.0.6 - 2018-03-15
 
 * Chore: minimum required `execa` version is now `^0.10.0`.

__tests__/index.test.js

@@ -54,6 +54,7 @@ function unlinkSyncSafe(dir) {
 
 describe("execa-webpack-plugin", () => {
   const dir = path.join(__dirname, "dir");
+  const otherDir = path.join(__dirname, "other-dir");
 
   it("should throw error when `onBuildStart`, `onBuildEnd` and `onBuildExit` options are empty", () =>
     expect(() => run()).toThrow());
@@ -198,7 +199,6 @@ describe("execa-webpack-plugin", () => {
     });
   });
 
-  // Need async test
   it("should throw error with `bail: true` option", () => {
     expect.assertions(1);
 
@@ -227,6 +227,34 @@ describe("execa-webpack-plugin", () => {
       });
   });
 
+  it("should throw error with `bail: true` option (async)", () => {
+    expect.assertions(1);
+
+    let catchError = null;
+
+    return run({
+      bail: true,
+      logLevel: "silent",
+      onBuildExit: [
+        {
+          cmd: "not-found"
+        }
+      ]
+    })
+      .catch(error => {
+        catchError = error;
+
+        return Promise.resolve();
+      })
+      .then(() => {
+        // execa not return error instanceOf Error
+        // expect(catchError).toBeInstanceOf(Error);
+        expect(catchError).not.toBeNull();
+
+        return Promise.resolve();
+      });
+  });
+
   it("should works and output 'stdout' and 'stderr' with `logLevel: 'info'` command", () =>
     run({
       logLevel: "info",
@@ -238,6 +266,17 @@ describe("execa-webpack-plugin", () => {
       ]
     }));
 
+  it("should works and output 'stdout' and 'stderr' with `logLevel: 'info'` command (async)", () =>
+    run({
+      logLevel: "info",
+      onBuildExit: [
+        {
+          args: [path.join(resourcesDir, "cli-stdout-stderr.js")],
+          cmd: "node"
+        }
+      ]
+    }));
+
   it("should works with nested commands", () => {
     expect.assertions(2);
 
@@ -266,6 +305,75 @@ describe("execa-webpack-plugin", () => {
     });
   });
 
+  it("should works with deep nested commands", () => {
+    expect.assertions(2);
+
+    mkdirSyncSafe(dir);
+
+    expect(fs.statSync(dir).isDirectory()).toBe(true);
+
+    return run({
+      onBuildStart: [
+        {
+          args: [
+            {
+              args: [
+                {
+                  args: [path.join(resourcesDir, "nested-nested.js")],
+                  cmd: "node"
+                }
+              ],
+              cmd: "node"
+            }
+          ],
+          cmd: "del"
+        }
+      ]
+    }).then(() => {
+      expect(() => fs.statSync(dir)).toThrow();
+
+      unlinkSyncSafe(dir);
+
+      return Promise.resolve();
+    });
+  });
+
+  it("should works with multiple nested commands", () => {
+    expect.assertions(4);
+
+    mkdirSyncSafe(dir);
+    mkdirSyncSafe(otherDir);
+
+    expect(fs.statSync(dir).isDirectory()).toBe(true);
+    expect(fs.statSync(otherDir).isDirectory()).toBe(true);
+
+    return run({
+      onBuildStart: [
+        {
+          args: [
+            {
+              args: [path.join(resourcesDir, "nested.js")],
+              cmd: "node"
+            },
+            {
+              args: [path.join(resourcesDir, "nested-other.js")],
+              cmd: "node"
+            }
+          ],
+          cmd: "del"
+        }
+      ]
+    }).then(() => {
+      expect(() => fs.statSync(dir)).toThrow();
+      expect(() => fs.statSync(otherDir)).toThrow();
+
+      unlinkSyncSafe(dir);
+      unlinkSyncSafe(otherDir);
+
+      return Promise.resolve();
+    });
+  });
+
   it("should works with nested commands (async)", () => {
     expect.assertions(2);
 
@@ -294,6 +402,75 @@ describe("execa-webpack-plugin", () => {
     });
   });
 
+  it("should works with deep nested commands (async)", () => {
+    expect.assertions(2);
+
+    mkdirSyncSafe(dir);
+
+    expect(fs.statSync(dir).isDirectory()).toBe(true);
+
+    return run({
+      onBuildExit: [
+        {
+          args: [
+            {
+              args: [
+                {
+                  args: [path.join(resourcesDir, "nested-nested.js")],
+                  cmd: "node"
+                }
+              ],
+              cmd: "node"
+            }
+          ],
+          cmd: "del"
+        }
+      ]
+    }).then(() => {
+      expect(() => fs.statSync(dir)).toThrow();
+
+      unlinkSyncSafe(dir);
+
+      return Promise.resolve();
+    });
+  });
+
+  it("should works with multiple nested commands (async)", () => {
+    expect.assertions(4);
+
+    mkdirSyncSafe(dir);
+    mkdirSyncSafe(otherDir);
+
+    expect(fs.statSync(dir).isDirectory()).toBe(true);
+    expect(fs.statSync(otherDir).isDirectory()).toBe(true);
+
+    return run({
+      onBuildExit: [
+        {
+          args: [
+            {
+              args: [path.join(resourcesDir, "nested.js")],
+              cmd: "node"
+            },
+            {
+              args: [path.join(resourcesDir, "nested-other.js")],
+              cmd: "node"
+            }
+          ],
+          cmd: "del"
+        }
+      ]
+    }).then(() => {
+      expect(() => fs.statSync(dir)).toThrow();
+      expect(() => fs.statSync(otherDir)).toThrow();
+
+      unlinkSyncSafe(dir);
+      unlinkSyncSafe(otherDir);
+
+      return Promise.resolve();
+    });
+  });
+
   it("should works when nested commands return nothing and 'bail: false'", () => {
     expect.assertions(1);
 
@@ -325,4 +502,36 @@ describe("execa-webpack-plugin", () => {
         return Promise.resolve();
       });
   });
+
+  it("should works when nested commands return nothing and 'bail: false' (async)", () => {
+    expect.assertions(1);
+
+    let catchError = null;
+
+    return run({
+      bail: false,
+      logLevel: "silent",
+      onBuildExit: [
+        {
+          args: [
+            {
+              args: [path.join(resourcesDir, "nothing.js")],
+              cmd: "node"
+            }
+          ],
+          cmd: "del"
+        }
+      ]
+    })
+      .catch(error => {
+        catchError = error;
+
+        return Promise.resolve();
+      })
+      .then(() => {
+        expect(catchError).toBeNull();
+
+        return Promise.resolve();
+      });
+  });
 });

__tests__/resources/nested-nested.js

@@ -0,0 +1,9 @@
+#!/usr/bin/env node
+
+"use strict";
+
+const path = require("path");
+
+const nested = path.join(__dirname, "nested.js");
+
+process.stdout.write(nested);

__tests__/resources/nested-other.js

@@ -0,0 +1,9 @@
+#!/usr/bin/env node
+
+"use strict";
+
+const path = require("path");
+
+const dir = path.join(__dirname, "../other-dir");
+
+process.stdout.write(dir);