Commit 4545e19
Fix HTTP pipeline async response crash by creating new req/resp per request
Instead of resetting the existing HttpRequest/HttpResponse objects in
HttpHandler::Reset(), create new ones. This prevents a race condition
where async handlers (holding shared_ptr references to the old req/resp)
could crash when FeedRecvData calls Reset() upon receiving HTTP pipeline
data or an attack while the async response is still being written.
The old req/resp objects remain alive through the shared_ptr references
held by the async handler, while the handler gets fresh objects for the
new incoming request.
Co-authored-by: ithewei <26049660+ithewei@users.noreply.github.com>1 parent 35c78cc commit 4545e19
1 file changed
Lines changed: 32 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
116 | 124 | | |
117 | 125 | | |
118 | 126 | | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
123 | 130 | | |
124 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
125 | 151 | | |
126 | 152 | | |
127 | 153 | | |
| |||
0 commit comments