fix: apply suggestions from ai code review

Author: ithewei

base/hbase.c

@@ -450,6 +450,7 @@ time_t hv_parse_time(const char* str) {
 }
 
 int hv_parse_url(hurl_t* stURL, const char* strURL) {
+    int ret = 0;
     if (stURL == NULL || strURL == NULL) return -1;
     memset(stURL, 0, sizeof(hurl_t));
     const char* begin = strURL;
@@ -504,14 +505,18 @@ int hv_parse_url(hurl_t* stURL, const char* strURL) {
         unsigned int parsed_port = 0;
         for (unsigned short i = 1; i <= stURL->fields[HV_URL_PORT].len; ++i) {
             if (port[i] < '0' || port[i] > '9') {
-                return -2;
+                ret = -2;
+                break;
             }
             parsed_port = parsed_port * 10 + (port[i] - '0');
             if (parsed_port > 65535) {
-                return -3;
+                ret = -3;
+                break;
             }
         }
-        stURL->port = (unsigned short)parsed_port;
+        if (ret == 0) {
+            stURL->port = (unsigned short)parsed_port;
+        }
     } else {
         port = ep;
         // set default port
@@ -526,25 +531,25 @@ int hv_parse_url(hurl_t* stURL, const char* strURL) {
         stURL->fields[HV_URL_HOST].off = host - begin;
         stURL->fields[HV_URL_HOST].len = port - host;
     }
-    if (ep == end) return 0;
+    if (ep == end) return ret;
     // /path
     sp = ep;
     ep = strchr(sp, '?');
     if (ep == NULL) ep = end;
     stURL->fields[HV_URL_PATH].off = sp - begin;
     stURL->fields[HV_URL_PATH].len = ep - sp;
-    if (ep == end) return 0;
+    if (ep == end) return ret;
     // ?query
     sp = ep + 1;
     ep = strchr(sp, '#');
     if (ep == NULL) ep = end;
     stURL->fields[HV_URL_QUERY].off = sp - begin;
     stURL->fields[HV_URL_QUERY].len = ep - sp;
-    if (ep == end) return 0;
+    if (ep == end) return ret;
     // #fragment
     sp = ep + 1;
     ep = end;
     stURL->fields[HV_URL_FRAGMENT].off = sp - begin;
     stURL->fields[HV_URL_FRAGMENT].len = ep - sp;
-    return 0;
+    return ret;
 }

base/hlog.c

@@ -29,20 +29,41 @@
 //#include "htime.h"
 #define SECONDS_PER_HOUR    3600
 #define SECONDS_PER_DAY     86400   // 24*3600
-#define SECONDS_PER_WEEK    604800  // 7*24*3600;
+#define SECONDS_PER_WEEK    604800  // 7*24*3600
+
+static inline struct tm* hv_localtime_r(time_t ts, struct tm* tm) {
+#ifdef _WIN32
+    localtime_s(tm, &ts);
+#else
+    tm = localtime_r(&ts, tm);
+#endif
+    return tm;
+}
+
+static inline struct tm* hv_gmtime_r(time_t ts, struct tm* tm) {
+#ifdef _WIN32
+    gmtime_s(tm, &ts);
+#else
+    tm = gmtime_r(&ts, tm);
+#endif
+    return tm;
+}
 
 static int s_gmtoff = 28800; // 8*3600
 static void init_gmtoff() {
     time_t ts = time(NULL);
-    struct tm* local_tm = localtime(&ts);
-    struct tm* gmt_tm = gmtime(&ts);
-    s_gmtoff =  (local_tm->tm_hour - gmt_tm->tm_hour) * 3600 +
-                (local_tm->tm_min - gmt_tm->tm_min) * 60 +
-                (local_tm->tm_sec - gmt_tm->tm_sec);
-
-    if (local_tm->tm_yday > gmt_tm->tm_yday) {
+    struct tm local_tm, gmt_tm;
+    memset(&local_tm, 0, sizeof(local_tm));
+    memset(&gmt_tm, 0, sizeof(gmt_tm));
+    hv_localtime_r(ts, &local_tm);
+    hv_gmtime_r(ts, &gmt_tm);
+    s_gmtoff =  (local_tm.tm_hour - gmt_tm.tm_hour) * 3600 +
+                (local_tm.tm_min - gmt_tm.tm_min) * 60 +
+                (local_tm.tm_sec - gmt_tm.tm_sec);
+
+    if (local_tm.tm_yday > gmt_tm.tm_yday) {
         s_gmtoff += SECONDS_PER_DAY;
-    } else if (local_tm->tm_yday < gmt_tm->tm_yday) {
+    } else if (local_tm.tm_yday < gmt_tm.tm_yday) {
         s_gmtoff -= SECONDS_PER_DAY;
     }
 }
@@ -222,12 +243,14 @@ const char* logger_get_cur_file(logger_t* logger) {
 }
 
 static void logfile_name(const char* filepath, time_t ts, char* buf, int len) {
-    struct tm* tm = localtime(&ts);
+    struct tm tm;
+    memset(&tm, 0, sizeof(tm));
+    hv_localtime_r(ts, &tm);
     snprintf(buf, len, "%s.%04d%02d%02d.log",
             filepath,
-            tm->tm_year+1900,
-            tm->tm_mon+1,
-            tm->tm_mday);
+            tm.tm_year+1900,
+            tm.tm_mon+1,
+            tm.tm_mday);
 }
 
 static void logfile_truncate(logger_t* logger) {