Skip to content

Commit f453d82

Browse files
authored
Merge pull request #537 from itk-dev/hotfix/5209-public-meeting-summary-cleanup
5209: Cleaned up public meeting summary view
2 parents 2091d53 + fb6e575 commit f453d82

4 files changed

Lines changed: 24 additions & 17 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
88

9+
* [PR-537](https://github.com/itk-dev/deltag.aarhus.dk/pull/537)
10+
5209: Cleaned up public meeting summary view
11+
912
## [4.11.0] - 2025-07-01
1013

1114
* [PR-533](https://github.com/itk-dev/deltag.aarhus.dk/pull/533)

web/modules/custom/hoeringsportal_public_meeting/src/Helper/PublicMeetingHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ public function hasDateEndingBetween(NodeInterface $node, ?\DateTimeInterface $f
381381
* @return \Drupal\itk_pretix\Plugin\Field\FieldType\PretixDate[]|iterable|null
382382
* The pretix dates if any.
383383
*/
384-
private function getPretixDates(NodeInterface $node): ?iterable {
384+
public function getPretixDates(NodeInterface $node): ?iterable {
385385
if (!$this->isPublicMeeting($node) || !$this->hasPretixSignUp($node)) {
386386
return NULL;
387387
}

web/modules/custom/hoeringsportal_public_meeting/templates/hoeringsportal-public-meeting-summary.html.twig

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,5 +101,7 @@
101101
{% endif %}
102102
{% endif %}
103103

104-
<h3 class="mt-3">{{ 'This event has multiple dates'|t }}</h3>
105-
<a href="#pretix_signup_list" class="btn btn-sm bg-primary text-white rounded py-1 px-3 mb-3">{{ 'View the list'|t }}</a>
104+
{% if public_meeting_helper.hasPretixSignUp(node) and public_meeting_helper.getPretixDates(node)|length > 1 %}
105+
<h3 class="mt-3">{{ 'This event has multiple dates'|t }}</h3>
106+
<a href="#pretix_signup_list" class="btn btn-sm bg-primary text-white rounded py-1 px-3 mb-3">{{ 'View the list'|t }}</a>
107+
{% endif %}

web/themes/custom/hoeringsportal/templates/field/field--dynamic-block-field--node-public-meeting-summary.html.twig

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@
3636
* @see template_preprocess_field()
3737
*/
3838
#}
39-
{% set node = element['#object'] %}
40-
{% set meeting_cancelled = public_meeting_helper.isCancelled(node) %}
41-
{% set meeting_has_been_held = public_meeting_helper.hasBeenHeld(node) %}
42-
{% set registration_deadline_passed = public_meeting_helper.isDeadlinePassed(node) %}
43-
4439
{% if label_hidden %}
4540
{% if multiple %}
4641
{% for item in items %}
@@ -68,15 +63,22 @@
6863
{% endif %}
6964
{% endif %}
7065

71-
{% if meeting_cancelled %}
72-
<div class="pretix-alert meeting-has-been-cancelled my-3">{{ 'Meeting has been cancelled'|t }}</div>
73-
{% elseif meeting_has_been_held %}
74-
<div class="pretix-alert meeting-has-been-held my-3">{{ 'Meeting has already been held'|t }}</div>
75-
{% else %}
76-
{% if registration_deadline_passed %}
77-
{# @TODO: Design: styling of "alert" #}
78-
<div class="pretix-alert pretix-alert-registration-deadline-passed my-3">{{ 'Registration deadline passed'|t }}</div>
66+
{% set node = element['#object'] %}
67+
{# pretix info is rendered in hoeringsportal-public-meeting-summary.html.twig #}
68+
{% if not public_meeting_helper.hasPretixSignUp(node) %}
69+
{% set meeting_cancelled = public_meeting_helper.isCancelled(node) %}
70+
{% set meeting_has_been_held = public_meeting_helper.hasBeenHeld(node) %}
71+
{% set registration_deadline_passed = public_meeting_helper.isDeadlinePassed(node) %}
72+
73+
{% if meeting_cancelled %}
74+
<div class="pretix-alert meeting-has-been-cancelled my-3">{{ 'Meeting has been cancelled'|t }}</div>
75+
{% elseif meeting_has_been_held %}
76+
<div class="pretix-alert meeting-has-been-held my-3">{{ 'Meeting has already been held'|t }}</div>
7977
{% else %}
80-
<a id="sign-up-shortcut" class="btn btn-primary btn-sm my-3" style="display: none">{{ 'Sign up for public meeting'|t }}</a>
78+
{% if registration_deadline_passed %}
79+
<div class="pretix-alert pretix-alert-registration-deadline-passed my-3">{{ 'Registration deadline passed'|t }}</div>
80+
{% else %}
81+
<a id="sign-up-shortcut" class="btn btn-primary btn-sm my-3" style="display: none">{{ 'Sign up for public meeting'|t }}</a>
82+
{% endif %}
8183
{% endif %}
8284
{% endif %}

0 commit comments

Comments
 (0)