Feature/promoted content paragraph#560
Merged
martinyde merged 10 commits intofeature/early_inclusion_dialoguefrom Nov 17, 2025
Merged
Feature/promoted content paragraph#560martinyde merged 10 commits intofeature/early_inclusion_dialoguefrom
martinyde merged 10 commits intofeature/early_inclusion_dialoguefrom
Conversation
…_content_paragraph
yepzdk
approved these changes
Nov 14, 2025
Contributor
yepzdk
left a comment
yepzdk
left a comment
There was a problem hiding this comment.
Looks good. Consider a small tweak for mobile, and also we might want to use this feature on project "sub" pages also.
| <h4 class="px-3">{{ left.leftLabel }}:</h4> | ||
| <div class="container"> | ||
| <div class="row"> | ||
| <div class="col-6"> |
Contributor
There was a problem hiding this comment.
Might want to use col-md-6 to wrap on mobile, and avoid very narrow column for the content.
| {% endif %} | ||
| </div> | ||
| {% if right %} | ||
| <div class="col-6"> |
rimi-itk
approved these changes
Nov 17, 2025
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Approved with a single suggestion.
| {{ 'Proposals received'|t }} | ||
| </div> | ||
| <div class="mb-4"> | ||
| <a data-dialog-options="{"width":800, "dialogueId":{{ elements['#node'].id }}, "originalPath":"{{ path('<current>') }}"}" data-dialog-type="modal" href="{{ path('node.add', {node_type: 'dialogue_proposal', dialogue: elements['#node'].id}) }}" class="use-ajax btn btn-primary text-white rounded">{{ 'Participate with your proposal'|t }}</a> |
Contributor
There was a problem hiding this comment.
The value of the data-dialog-options attribute is hard to read (and write). Consider using an object and let Twig do the JSON encoding:
Suggested change
| <a data-dialog-options="{"width":800, "dialogueId":{{ elements['#node'].id }}, "originalPath":"{{ path('<current>') }}"}" data-dialog-type="modal" href="{{ path('node.add', {node_type: 'dialogue_proposal', dialogue: elements['#node'].id}) }}" class="use-ajax btn btn-primary text-white rounded">{{ 'Participate with your proposal'|t }}</a> | |
| {% set = dialog_option = { | |
| width: 800, | |
| dialogueId: elements['#node'].id, | |
| originalPath: path('<current>'), | |
| } %} | |
| <a data-dialog-options="{{ dialog_option|json_encode }}" data-dialog-type="modal" href="{{ path('node.add', {node_type: 'dialogue_proposal', dialogue: elements['#node'].id}) }}" class="use-ajax btn btn-primary text-white rounded">{{ 'Participate with your proposal'|t }}</a> |
martinyde
merged commit 540dece
into
feature/early_inclusion_dialogue
18 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/5801
Description
Screenshots