Refactor timeline CSS to follow project conventions#594
Merged
yepzdk merged 2 commits intofeature/timeline-conversion2from Jan 23, 2026
Merged
Refactor timeline CSS to follow project conventions#594yepzdk merged 2 commits intofeature/timeline-conversion2from
yepzdk merged 2 commits intofeature/timeline-conversion2from
Conversation
- Replaced hardcoded hex colors with project color tokens - Removed font-family override to inherit from theme - Created SCSS mixins for status and accent variant styles - Used @for loop for z-index declarations - Replaced magic numbers with SCSS variables - Converted CSS comments to SCSS comments - Used SCSS nesting for better organization Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
martinyde
reviewed
Jan 23, 2026
| // ============================================================================= | ||
|
|
||
| // Layout variables | ||
| $timeline-max-width: 900px; |
Contributor
There was a problem hiding this comment.
Is this right? (px width)
Contributor
Author
There was a problem hiding this comment.
Fixed with bootstrap container widts
| font-size: $font-size-base; | ||
| line-height: $line-height-base; | ||
| color: var(--text-secondary); | ||
| max-width: 600px; |
Contributor
Author
There was a problem hiding this comment.
Fixed with bootstrap container widts
Addresses PR review feedback: - $timeline-max-width: uses lg container (960px) - Description max-width: uses sm container (540px) - Legend max-width: uses sm container (540px) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_color-tokens.scss@forloop for z-index declarations (10 rules → 1 loop)$spacer,$timeline-card-gap, etc.)Test plan
🤖 Generated with Claude Code