Merged
Conversation
rimi-itk
reviewed
Mar 3, 2026
Contributor
rimi-itk
left a comment
There was a problem hiding this comment.
I think that this works as expected, but I have asked some questions and added some comments.
rimi-itk
approved these changes
Mar 7, 2026
Contributor
rimi-itk
left a comment
There was a problem hiding this comment.
Approved, but I think we should go for the right solution when loading timeline paragraphs (i.e. not use an entity query, but ask the node for it's paragraphs) so we don't make assumptions on whether or not orphaned paragraphs are actually deleted from the database.
…sportal_project.da.po Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
94c6a65 to
278377a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/6839
Description
Handle orphaned paragraphs on presave and with update hook.
Audit check fails are handled in different PR