Skip to content

Hotfix/handle orphaned paragraphs#633

Merged
rimi-itk merged 8 commits intodevelopfrom
hotfix/handle-orphaned-paragraphs
Mar 9, 2026
Merged

Hotfix/handle orphaned paragraphs#633
rimi-itk merged 8 commits intodevelopfrom
hotfix/handle-orphaned-paragraphs

Conversation

@martinyde
Copy link
Copy Markdown
Contributor

@martinyde martinyde commented Mar 3, 2026

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/6839

Description

Handle orphaned paragraphs on presave and with update hook.

Audit check fails are handled in different PR

@martinyde martinyde requested a review from rimi-itk March 3, 2026 12:29
Copy link
Copy Markdown
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this works as expected, but I have asked some questions and added some comments.

Comment thread web/modules/custom/hoeringsportal_project/src/Helper/ProjectHelper.php Outdated
Comment thread config/sync/locale.settings.yml
Comment thread web/modules/custom/hoeringsportal_project/src/Helper/ProjectHelper.php Outdated
Comment thread web/modules/custom/hoeringsportal_project/src/Helper/ProjectHelper.php Outdated
@martinyde martinyde requested a review from rimi-itk March 6, 2026 09:13
Copy link
Copy Markdown
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I think we should go for the right solution when loading timeline paragraphs (i.e. not use an entity query, but ask the node for it's paragraphs) so we don't make assumptions on whether or not orphaned paragraphs are actually deleted from the database.

@rimi-itk rimi-itk force-pushed the hotfix/handle-orphaned-paragraphs branch from 94c6a65 to 278377a Compare March 9, 2026 09:43
@rimi-itk rimi-itk merged commit 3954cd3 into develop Mar 9, 2026
16 of 21 checks passed
@rimi-itk rimi-itk deleted the hotfix/handle-orphaned-paragraphs branch March 9, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants