Skip to content

Switch away from dawa#658

Merged
martinyde merged 9 commits into
developfrom
feature/dawa-adressevaelger-shift
Jun 2, 2026
Merged

Switch away from dawa#658
martinyde merged 9 commits into
developfrom
feature/dawa-adressevaelger-shift

Conversation

@martinyde

@martinyde martinyde commented May 22, 2026

Copy link
Copy Markdown
Contributor

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/7543

Description

Changes to hoeringsportal_forms:

Changes to hoeringsportal_activity

  • Change naming to match hoeringsportal_forms

Changes to hoeringsportal_deskpro

  • Change form to use one input field for address selection
  • Use the library definition in hoeringsportal_forms instead of it's own implementation
  • Hide old fields but enrich from Address search field to maintain old form submit handling
  • Use proj4 to convert coordinates in frontend

Old form output:

{
    "person_name": "Martin yde Granath",
    "email": "yde001@gmail.com",
    "address_secret": 0,
    "postal_code": "",
    "representation": "5",
    "organization": "",
    "subject": "test",
    "message": "test",
    "address": "Nymarksvej 14B, 8320 Mårslet",
    "geolocation": "10.16592894, 56.06235123"
}

New form output:

{
    "person_name": "Martin yde Granath",
    "email": "yde001@gmail.com",
    "address_secret": 0,
    "postal_code": "8320",
    "geolocation": "10.16592894, 56.06235123",
    "representation": "5",
    "organization": "",
    "subject": "test",
    "message": "test",
    "address": "Nymarksvej 14B, 8320 Mårslet"

Changes to itk-dev/itk-pretix
Changed composer dependency to require https://github.com/itk-dev/itk_pretix/tree/feature/dawa-adressevaelger-shift

Changes to hoeringsportal_data
@todo Awaiting response from Septima regarding approach.

Screenshot

** Create hearing reply **
Skærmbillede 2026-05-22 kl  12 17 58

@martinyde martinyde requested a review from rimi-itk May 22, 2026 13:15
@martinyde martinyde marked this pull request as ready for review May 22, 2026 13:15
@martinyde martinyde requested a review from rimi-itk June 2, 2026 08:20

@rimi-itk rimi-itk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@martinyde martinyde merged commit 746e214 into develop Jun 2, 2026
18 of 21 checks passed
@martinyde martinyde deleted the feature/dawa-adressevaelger-shift branch June 2, 2026 11:26
@rimi-itk rimi-itk mentioned this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants