Feature: Cybersikkerhedsrapport#264
Merged
Merged
Conversation
jeppekroghitk
force-pushed
the
feature/6262-cybersikkerheds-rapport
branch
from
3e81585 to
c4aa6f8
Compare
tuj
requested changes
May 19, 2026
|
|
||
| $requestData = $request->query->all('cybersecurity_report'); | ||
|
|
||
| $dataProviderId = ($requestData['dataProvider'] ?? null) ?: $this->defaultDataProvider; |
Contributor
There was a problem hiding this comment.
Should we ignore the dataProvider stuff and just get from all data providers?
| */ | ||
| public function buildForm(FormBuilderInterface $builder, array $options): void | ||
| { | ||
| $dataProviders = $this->dataProviderRepository->findAll(); |
Contributor
There was a problem hiding this comment.
Can we write data provider out of this, so it just applies to all data providers?
jeppekroghitk
force-pushed
the
feature/6262-cybersikkerheds-rapport
branch
from
a2e98ff to
82e8d43
Compare
jeppekroghitk
force-pushed
the
feature/6262-cybersikkerheds-rapport
branch
from
f2dcd66 to
9100ad4
Compare
tuj
requested changes
May 22, 2026
| public function buildForm(FormBuilderInterface $builder, array $options): void | ||
| { | ||
| $builder | ||
| ->add('versionTitle', ChoiceType::class, [ |
Contributor
There was a problem hiding this comment.
Why this choice, when there is only one option?
Contributor
Author
There was a problem hiding this comment.
To trivialize the addition of more versions in the future. AFAIR it was requested, so i chose to implement it like this.
| public function getWorklogsByIssueAndPeriod(int $issueId, ?\DateTimeInterface $fromDate, ?\DateTimeInterface $toDate): array | ||
| { | ||
| $qb = $this->createQueryBuilder('w') | ||
| ->andWhere('w.issue = :issue') // <-- use the entity relation |
| { | ||
| $qb = $this->createQueryBuilder('w') | ||
| ->andWhere('w.issue = :issue') // <-- use the entity relation | ||
| ->setParameter('issue', $issueId); // Doctrine can accept the ID for a ManyToOne |
| @@ -0,0 +1,490 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
Baseline has been removed from develop since the shift from psalm to phpstan. Remove this file.
tuj
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
#6262
Description
Adds a report that shows hours logged on all worklogs for all tickets with the version "Cybersikkerhedsaftale" in all projects for a given time period, and renders them in a table.
Screenshot of the result
Checklist