Flipped archived filter default

Author: tuj

README.md

@@ -160,9 +160,9 @@ itk_dev_entity:
     enabled: true
 ```
 
-`$entity->archive($at)` sets `archivedAt`. The `archivable` SQL filter is registered **disabled** — toggle it
-per-request (typically via a `?showArchived=1` listener that calls `$em->getFilters()->enable('archivable')`) to hide
-archived rows from `findAll`/`find`.
+`$entity->archive($at)` sets `archivedAt`. The `archivable` SQL filter is registered **enabled**, so archived rows
+are hidden from `findAll`/`find` by default. Disable it per-request (typically via a `?showArchived=1` listener that
+calls `$em->getFilters()->disable('archivable')`) when you want archived rows to appear.
 
 If `archivable.enabled` is left off, the filter is never registered — entities that use `ArchivableTrait` will still
 have the `archived_at` column and the `archive()`/`unarchive()` methods, but enabling the filter will throw.
@@ -406,7 +406,7 @@ itk_dev_entity:
 | `audit.retention`           | ISO-8601 duration        | `P1Y`                                 | Default retention past which audit rows are scrubbed by `privacy:anonymize-stale`.                                                                                                                                                                                                        |
 | `audit.retention_overrides` | map<FQCN, ISO8601> | `[]`                                  | Per-entity overrides.                                                                                                                                                                                                                                                                     |
 | `soft_delete.enabled`       | bool                     | `false`                               | Register `SoftDeleteListener` (intercepts `remove()`) and the `soft_delete` Doctrine filter. Entities still opt in by implementing `SoftDeletableInterface` and using `SoftDeletableTrait`.                                                                                               |
-| `archivable.enabled`        | bool                     | `false`                               | Register the `archivable` Doctrine filter (registered disabled; toggle per-request). Entities still opt in by implementing `ArchivableInterface` and using `ArchivableTrait`.                                                                                                             |
+| `archivable.enabled`        | bool                     | `false`                               | Register the `archivable` Doctrine filter (registered enabled; hides archived rows by default; disable per-request to reveal them). Entities still opt in by implementing `ArchivableInterface` and using `ArchivableTrait`.                                                              |
 | `timestampable.enabled`     | bool                     | `false`                               | Register `TimestampableListener` (sets `createdAt`/`updatedAt`). Entities still opt in by implementing `TimestampableInterface` and using `TimestampableTrait`.                                                                                                                           |
 | `blameable.enabled`         | bool                     | `false`                               | Register `BlameableListener` (sets `createdBy`/`modifiedBy` from the security token). Entities still opt in by implementing `BlameableInterface` and using `BlameableTrait`.                                                                                                              |
 | `anonymization.enabled`     | bool                     | `false`                               | Discover `#[Anonymize]` property attributes, register privacy services, and expose the `privacy:anonymize` and `privacy:anonymize-stale` commands. Entities still opt in by implementing `AnonymizationStatusInterface`, using `AnonymizationStatusTrait`, and annotating PII properties. |

config/reference.php

@@ -1248,7 +1248,7 @@
  *         enabled?: bool|Param, // When true, registers the soft_delete Doctrine filter and listener. Entities still opt in by implementing SoftDeletableInterface and using SoftDeletableTrait. // Default: false
  *     },
  *     archivable?: array{
- *         enabled?: bool|Param, // When true, registers the archivable Doctrine filter (registered disabled; toggle per-request via $em->getFilters()->enable('archivable')). Entities still opt in by implementing ArchivableInterface and using ArchivableTrait. // Default: false
+ *         enabled?: bool|Param, // When true, registers the archivable Doctrine filter (registered enabled; archived rows are hidden by default — disable per-request via $em->getFilters()->disable('archivable') to reveal them). Entities still opt in by implementing ArchivableInterface and using ArchivableTrait. // Default: false
  *     },
  *     timestampable?: array{
  *         enabled?: bool|Param, // When true, registers the onFlush listener that sets createdAt/updatedAt. Entities still opt in by implementing TimestampableInterface and using TimestampableTrait. // Default: false

src/DependencyInjection/Configuration.php

@@ -65,7 +65,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->children()
                         ->booleanNode('enabled')
                             ->defaultFalse()
-                            ->info('When true, registers the archivable Doctrine filter (registered disabled; toggle per-request via $em->getFilters()->enable(\'archivable\')). Entities still opt in by implementing ArchivableInterface and using ArchivableTrait.')
+                            ->info('When true, registers the archivable Doctrine filter (registered enabled; archived rows are hidden by default — disable per-request via $em->getFilters()->disable(\'archivable\') to reveal them). Entities still opt in by implementing ArchivableInterface and using ArchivableTrait.')
                         ->end()
                     ->end()
                 ->end()

src/DependencyInjection/ITKDevEntityExtension.php

@@ -89,7 +89,7 @@ public function prepend(ContainerBuilder $container): void
         if ($config['archivable']['enabled']) {
             $filters['archivable'] = [
                 'class' => ArchivableFilter::class,
-                'enabled' => false,
+                'enabled' => true,
             ];
         }
         if ($config['soft_delete']['enabled']) {

tests/Integration/AbstractITKDevEntityIntegrationTest.php

@@ -152,18 +152,19 @@ public function testSoftDeleteAndArchivableFiltersCompose(): void
         $this->em->flush();
         $this->em->clear();
 
-        // soft_delete on (default), archivable off (default) -> live + archivedOnly visible.
+        // Both filters on (default) -> only `live`.
         $visible = $this->labelsOf($this->em->getRepository(FixtureEntity::class)->findAll());
-        sort($visible);
-        self::assertSame(['archived', 'live'], $visible);
+        self::assertSame(['live'], $visible);
 
-        // Both filters on -> only `live`.
-        $this->em->getFilters()->enable('archivable');
+        // soft_delete on, archivable off -> live + archived.
+        $this->em->getFilters()->disable('archivable');
         $this->em->clear();
         $visible = $this->labelsOf($this->em->getRepository(FixtureEntity::class)->findAll());
-        self::assertSame(['live'], $visible);
+        sort($visible);
+        self::assertSame(['archived', 'live'], $visible);
 
         // soft_delete off, archivable on -> live + soft-deleted.
+        $this->em->getFilters()->enable('archivable');
         $this->em->getFilters()->disable('soft_delete');
         $this->em->clear();
         $visible = $this->labelsOf($this->em->getRepository(FixtureEntity::class)->findAll());
@@ -223,7 +224,7 @@ public function testSecondRemoveAfterSoftDeleteHardDeletes(): void
         self::assertNull($found, 'second remove() should hard-delete an already soft-deleted row');
     }
 
-    public function testArchivableFilterHidesArchivedRowsWhenEnabled(): void
+    public function testArchivableFilterHidesArchivedRowsByDefault(): void
     {
         $live = new FixtureEntity();
         $live->setLabel('live');
@@ -236,16 +237,16 @@ public function testArchivableFilterHidesArchivedRowsWhenEnabled(): void
         $this->em->flush();
         $this->em->clear();
 
-        // Filter disabled by default — both visible
-        $all = $this->em->getRepository(FixtureEntity::class)->findAll();
-        self::assertCount(2, $all);
-
-        // Enable filter — only live row visible
-        $this->em->getFilters()->enable('archivable');
-        $this->em->clear();
+        // Filter enabled by default — only live row visible
         $visible = $this->em->getRepository(FixtureEntity::class)->findAll();
         self::assertCount(1, $visible);
         self::assertSame('live', $visible[0]->getLabel());
+
+        // Disable filter — both rows visible
+        $this->em->getFilters()->disable('archivable');
+        $this->em->clear();
+        $all = $this->em->getRepository(FixtureEntity::class)->findAll();
+        self::assertCount(2, $all);
     }
 
     public function testArchivableFilterReturnsNoConstraintForNonArchivableEntity(): void

tests/Unit/DependencyInjection/ArchivableConfigTest.php

@@ -22,7 +22,7 @@ public function testDefaultsToDisabledNoDoctrineFilter(): void
         self::assertArrayNotHasKey('archivable', $filters, 'archivable Doctrine filter must not be prepended when disabled');
     }
 
-    public function testExplicitlyEnabledRegistersFilterDisabledByDefault(): void
+    public function testExplicitlyEnabledRegistersFilterEnabledByDefault(): void
     {
         $config = [
             'user_class' => 'App\\Entity\\User',
@@ -35,7 +35,7 @@ public function testExplicitlyEnabledRegistersFilterDisabledByDefault(): void
         $doctrine = $prepend->getExtensionConfig('doctrine');
         $filters = $doctrine[0]['orm']['filters'] ?? [];
         self::assertArrayHasKey('archivable', $filters);
-        self::assertFalse($filters['archivable']['enabled'], 'archivable filter is registered disabled so it can be toggled per-request');
+        self::assertTrue($filters['archivable']['enabled'], 'archivable filter is registered enabled so archived rows are hidden by default; disable per-request to reveal');
     }
 
     /** @param array<string, mixed> $config */