Cleaned up

Author: rimi-itk

README.md

@@ -20,6 +20,8 @@ F2_API_URI=
 F2_API_USERNAME=
 F2_API_SECRET=
 F2_F2_USERNAME=
+
+F2_API_TIME_ZONE=
 ```
 
 Run
@@ -54,8 +56,8 @@ task f2-api-client:run -- caseById 2204
 For development (and testing) a couple of useful tasks are defined:
 
 ``` text
-* f2-api-client:debug:       Debug bin/f2-api-client inside docker compose setup, e.g. `task f2-api-client:debug -- searchCases '{"q": "test", "count": 10}'`
-* f2-api-client:run:         Run bin/f2-api-client inside docker compose setup, e.g. `task f2-api-client:run -- searchCases '{"q": "test", "count": 10}'`
+* f2-api-client:run:         Run bin/f2-api-client inside docker compose setup, e.g. `task f2-api-client:run -- caseSearch 'test'`
+* f2-api-client:debug:       Debug bin/f2-api-client inside docker compose setup, e.g. `task f2-api-client:debug -- caseSearch 'test'`
 ```
 
 ### F2 REST documentation

src/Client/ApiClient.php

@@ -87,7 +87,7 @@ public function caseSearch(string $searchTerms, int $count = 10): array
         return $this->createSearchResult($response);
     }
 
-    public function caseById(string $id): CaseFile
+    public function caseById(int $id): CaseFile
     {
         $url = $this->getRequestUrl('http://cbrain.com/casefile/rel/case-by-id', [
             'id' => $id,
@@ -114,7 +114,7 @@ public function matterSearch(string $searchTerms, int $count = 10): array
         return $this->createSearchResult($response);
     }
 
-    public function matterById(string $id): Matter
+    public function matterById(int $id): Matter
     {
         $url = $this->getRequestUrl('http://cbrain.com/casefile/rel/matter-by-id', [
             'id' => $id,
@@ -142,7 +142,7 @@ public function matterByMatterNumber(string $matterNumber): Matter
         return $this->createItemResult($response, Matter::class);
     }
 
-    public function documentById(string $id): Document
+    public function documentById(int $id): Document
     {
         $url = $this->getRequestUrl('http://cbrain.com/casefile/rel/document-by-id', [
             'id' => $id,
@@ -229,7 +229,7 @@ protected function configureOptions(OptionsResolver $resolver): void
             ->setAllowedTypes('cache_item_pool', CacheItemPoolInterface::class);
     }
 
-    protected function getRequestUrl(string $rel, array $values): string
+    protected function getRequestUrl(string $rel, array $values = []): string
     {
         $index = $this->getServiceIndex();
 

src/Command/F2ApiClientCommand.php

@@ -34,11 +34,11 @@ public function __invoke(
         $response = match ($action) {
             'getServiceIndex' => $client->getServiceIndex(),
             'caseSearch' => $client->caseSearch((string) $arg),
-            'caseById' => $client->caseById((string) $arg),
+            'caseById' => $client->caseById((int) $arg),
             'matterSearch' => $client->matterSearch((string) $arg),
-            'matterById' => $client->matterById((string) $arg),
+            'matterById' => $client->matterById((int) $arg),
             'matterByMatterNumber' => $client->matterByMatterNumber((string) $arg),
-            'documentById' => $client->documentById((string) $arg),
+            'documentById' => $client->documentById((int) $arg),
             default => throw new InvalidArgumentException(sprintf('Invalid action: %s', $action)),
         };
 

src/Model/F2Item.php

@@ -6,7 +6,7 @@
 
 use ItkDev\F2ApiClient\Model\F2Item\Links;
 
-abstract class F2Item extends AbstractItem
+abstract class F2Item extends AbstractItem implements \Stringable
 {
     public ?int $id = null;
     public ?Links $links = null;