Skip to content

First take on a PR skill#8

Open
cableman wants to merge 3 commits into
mainfrom
feature/pr-skill
Open

First take on a PR skill#8
cableman wants to merge 3 commits into
mainfrom
feature/pr-skill

Conversation

@cableman

Copy link
Copy Markdown

Main take away use PR template if one exists in the project.

@cableman cableman requested a review from yepzdk June 12, 2026 12:09

@yepzdk yepzdk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory is skills/itkdev-pr/ but the skill declares name: pr-description. Every other skill in this plugin is namespaced itkdev-* (itkdev-adr, itkdev-documentation, itkdev-issue-workflow, itkdev-github-guidelines), and the namespace is what users type to invoke it (/itkdev-...). An un-prefixed pr-description breaks that pattern and is harder to discover among the others.
Could we rename it to name: itkdev-pr to match both the directory and the rest of the plugin?
Otherwise this looks good.

@cableman cableman requested a review from martinyde June 15, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants