First take on a PR skill#8
Open
cableman wants to merge 3 commits into
Open
Conversation
yepzdk
reviewed
Jun 12, 2026
yepzdk
left a comment
Contributor
There was a problem hiding this comment.
The directory is skills/itkdev-pr/ but the skill declares name: pr-description. Every other skill in this plugin is namespaced itkdev-* (itkdev-adr, itkdev-documentation, itkdev-issue-workflow, itkdev-github-guidelines), and the namespace is what users type to invoke it (/itkdev-...). An un-prefixed pr-description breaks that pattern and is harder to discover among the others.
Could we rename it to name: itkdev-pr to match both the directory and the rest of the plugin?
Otherwise this looks good.
martinyde
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main take away use PR template if one exists in the project.