Allowed both key and form configuration of providers - #24
Conversation
# Conflicts: # CHANGELOG.md # composer.json # os2forms_nemlogin_openid_connect.info.yml # src/Controller/OpenIDConnectController.php
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
5c84424 to
08d206b
Compare
| "drupal/webform": "^6.0", | ||
| "itk-dev/drupal_psr6_cache": "^1.0", | ||
| "itk-dev/openid-connect": "^3.1", | ||
| "os2web/os2web_audit": "^0.1", |
There was a problem hiding this comment.
Why is this added in a pull request related to keys?
There was a problem hiding this comment.
A duplicate require and require-dev is added to composer.json in #20. This was somehow missed by myself in a review.
The duplicated require contained "os2forms/os2forms": "^3.17", in which the os2web/os2web_audit requirement came from. However, the only thing needed from os2forms is os2web_audit.
There was a problem hiding this comment.
But why do we need “audit” in a pull request related to "key"?
There was a problem hiding this comment.
We don't - we just need to not remove it.
#20 mistakenly adds an extra require and require-dev section before the original one. This newly added require section is missing the os2forms requirement that the original one had.
I suppose your right in that this change from a full os2forms requirement to a direct audit requirement could have it's own PR. I will update with the original requirement.
afc6896 to
0332522
Compare
2 participants
https://leantime.itkdev.dk/#/tickets/showTicket/2726
See itk-dev/os2forms_payment#4 for note about mglaman/phpstan-drupal.