Skip to content

Generate and use unique token keys across OIDC providers #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jekuaitk merged 4 commits into from
Jul 14, 2026
Merged

Generate and use unique token keys across OIDC providers #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90814fe
Generate and use unique token keys across OIDC providers
jekuaitk Feb 26, 2026
c63c0c2
Applied coding standards
jekuaitk Feb 26, 2026
2a8fd13
Merge branch 'main' into feature/unique-token-keys-for-oidcs-providers
jekuaitk Jul 14, 2026
2e58fe9
Updated CHANGELOg
jekuaitk Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [2.5.0] 2026-07-14

* Use unique token keys for OIDC providers.

## [2.4.1] 2026-04-21

* Fetched providers as array when displaying them.
Expand Down Expand Up @@ -49,7 +53,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

* Allowed multiple providers.

[Unreleased]: https://github.com/itk-dev/os2forms_nemlogin_openid_connect/compare/2.4.1...HEAD
[Unreleased]: https://github.com/itk-dev/os2forms_nemlogin_openid_connect/compare/2.5.0...HEAD
[2.5.0]: https://github.com/itk-dev/os2forms_nemlogin_openid_connect/compare/2.4.1...2.5.0
[2.4.1]: https://github.com/itk-dev/os2forms_nemlogin_openid_connect/compare/2.4.0...2.4.1
[2.4.0]: https://github.com/itk-dev/os2forms_nemlogin_openid_connect/compare/2.3.1...2.4.0
[2.3.1]: https://github.com/itk-dev/os2forms_nemlogin_openid_connect/compare/2.3.0...2.3.1
Expand Down
14 changes: 11 additions & 3 deletions src/Plugin/os2web/NemloginAuthProvider/OpenIDConnect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public function logout() {
* @phpstan-param array<string, mixed> $token
*/
public function setToken(array $token): self {
$this->session->set(self::SESSION_TOKEN, $token);
$this->session->set($this->getTokenKey(), $token);

return $this;
}
Expand All @@ -250,9 +250,10 @@ public function setToken(array $token): self {
* @phpstan-return array<string, mixed>|null
*/
private function getToken(bool $clear = FALSE): ?array {
$token = $this->session->get(self::SESSION_TOKEN);
$tokenKey = $this->getTokenKey();
$token = $this->session->get($tokenKey);
if ($clear) {
$this->session->remove(self::SESSION_TOKEN);
$this->session->remove($tokenKey);
}

return $token;
Expand Down Expand Up @@ -535,4 +536,11 @@ private function getClaimKeys(): array {
return $keys;
}

/**
* Get unique token key.
*/
private function getTokenKey(): string {
return self::SESSION_TOKEN . '_' . $this->getPluginId();
}

}
Loading