Skip to content

Commit 537374b

Browse files
authored
Merge pull request #29 from itk-dev/feature/move-category-to-bottom
refactor: move Kategori field to bottom of submission form
2 parents f7d0148 + 14d8458 commit 537374b

3 files changed

Lines changed: 22 additions & 22 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
1010
- Raised card, input, dropdown and divider borders to a WCAG 1.4.11-compliant `#8c8c8c` (3.36:1 on white, up from ~1.2:1) via the `--border-default`/`--border-subtle` tokens; repointed the structural separator borders that hardcoded `--gray-200`/`--gray-350` at `--border-subtle`
1111
- Fixed muted text contrast: `--text-muted` now `#767676` (4.54:1 on white); the dark-footer bottom links use `--gray-350` (9.48:1 on `#333`) instead of the failing `--gray-600` (3.42:1)
1212
- Added an outline "Skriv et høringssvar" button in the hearing header (hidden on the closed variant) and a centered primary one below the answers list, in addition to the existing one above; all three share a `js-submit-horingssvar` hook wired in `variant.js`
13-
- Added help text "Vælg hvilken kategori dit høringssvar passer til" to the Kategori select, linked via `aria-describedby`
13+
- Added help text "Vælg hvilken kategori dit høringssvar passer til" to the Kategori select, linked via `aria-describedby`, and moved the Kategori field to the bottom of the "Indsend høringssvar" form (after the answer text) in both prototypes
1414
- Added a tip on the closed ("Afsluttet") variant linking down to the statistics section: "Se længere nede hvordan høringssvarene har fordelt sig"
1515
- Submission-form hint and notice text darkened to `--text-secondary` (gray-700, ~7:1) and the hint de-italicised for readability at the small size; the notice info icon now follows the text colour (`currentColor`) instead of the near-invisible `--gray-400`
1616
- Reframed the per-answer "synes om" like as an agreement vote: handshake icon (`fa-regular fa-handshake`) and the text "{antal} er enig(e)" (singular-aware), with the sort option renamed "Flest enige". Applied to both cards and the detail modal across the Vosnæs and Uniparken prototypes (shared JS); the underlying `likes` data field is unchanged

docs/public/projects/deltag-aarhus/mocks/index.html

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -671,17 +671,6 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
671671
</div>
672672
<div class="modal__body">
673673
<form class="submission-form" id="submission-form">
674-
<div class="submission-form__field">
675-
<label for="submission-category" class="submission-form__label">Kategori</label>
676-
<select id="submission-category" class="submission-form__select" aria-describedby="submission-category-hint" required>
677-
<option value="">Vælg kategori...</option>
678-
<option value="miljoe">Miljø/Natur</option>
679-
<option value="stoej">Støj/Sundhed</option>
680-
<option value="landskab">Landskab/Visuel</option>
681-
<option value="proces">Proces/Andet</option>
682-
</select>
683-
<span class="submission-form__hint" id="submission-category-hint">Vælg hvilken kategori dit høringssvar passer til</span>
684-
</div>
685674
<div class="submission-form__field">
686675
<label for="submission-name" class="submission-form__label">Dit navn</label>
687676
<input type="text" id="submission-name" class="submission-form__input" value="Maria Jensen" readonly>
@@ -695,6 +684,17 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
695684
<label for="submission-body" class="submission-form__label">Dit høringssvar</label>
696685
<textarea id="submission-body" class="submission-form__textarea" rows="8" required placeholder="Beskriv dine synspunkter, bekymringer eller forslag vedrørende planen..."></textarea>
697686
</div>
687+
<div class="submission-form__field">
688+
<label for="submission-category" class="submission-form__label">Kategori</label>
689+
<select id="submission-category" class="submission-form__select" aria-describedby="submission-category-hint" required>
690+
<option value="">Vælg kategori...</option>
691+
<option value="miljoe">Miljø/Natur</option>
692+
<option value="stoej">Støj/Sundhed</option>
693+
<option value="landskab">Landskab/Visuel</option>
694+
<option value="proces">Proces/Andet</option>
695+
</select>
696+
<span class="submission-form__hint" id="submission-category-hint">Vælg hvilken kategori dit høringssvar passer til</span>
697+
</div>
698698
<div class="submission-form__notice">
699699
<i class="fa-solid fa-circle-info" aria-hidden="true"></i>
700700
<p>Alle høringssvar er omfattet af offentlighedsloven. Dit navn og høringssvar vil blive offentliggjort i forbindelse med byrådets politiske behandling.</p>

docs/public/projects/deltag-aarhus/mocks/uniparken/index.html

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -660,16 +660,6 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
660660
</div>
661661
<div class="modal__body">
662662
<form class="submission-form" id="submission-form">
663-
<div class="submission-form__field">
664-
<label for="submission-category" class="submission-form__label">Kategori</label>
665-
<select id="submission-category" class="submission-form__select" required>
666-
<option value="">Vælg kategori...</option>
667-
<option value="miljoe">Miljø/Natur</option>
668-
<option value="stoej">Støj/Sundhed</option>
669-
<option value="landskab">Landskab/Visuel</option>
670-
<option value="proces">Proces/Andet</option>
671-
</select>
672-
</div>
673663
<div class="submission-form__field">
674664
<label for="submission-name" class="submission-form__label">Dit navn</label>
675665
<input type="text" id="submission-name" class="submission-form__input" value="Marie Holm" readonly>
@@ -683,6 +673,16 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
683673
<label for="submission-body" class="submission-form__label">Dit høringssvar</label>
684674
<textarea id="submission-body" class="submission-form__textarea" rows="8" required placeholder="Beskriv dine synspunkter, bekymringer eller forslag vedrørende planen..."></textarea>
685675
</div>
676+
<div class="submission-form__field">
677+
<label for="submission-category" class="submission-form__label">Kategori</label>
678+
<select id="submission-category" class="submission-form__select" required>
679+
<option value="">Vælg kategori...</option>
680+
<option value="miljoe">Miljø/Natur</option>
681+
<option value="stoej">Støj/Sundhed</option>
682+
<option value="landskab">Landskab/Visuel</option>
683+
<option value="proces">Proces/Andet</option>
684+
</select>
685+
</div>
686686
<div class="submission-form__notice">
687687
<i class="fa-solid fa-circle-info" aria-hidden="true"></i>
688688
<p>Alle høringssvar er omfattet af offentlighedsloven. Dit navn og høringssvar vil blive offentliggjort i forbindelse med byrådets politiske behandling.</p>

0 commit comments

Comments
 (0)