Skip to content

Commit 5d36cf9

Browse files
committed
Tweak ResourceComparatorCompareTests
1 parent 4ef448d commit 5d36cf9

2 files changed

Lines changed: 12 additions & 28 deletions

File tree

Tests/appstoreconnect-cliTests/Sync/ResourceComparatorCompareGroupsTests.swift

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ final class ResourceComparatorCompareGroupsTests: XCTestCase {
99

1010
func testCompareBetaGroups() {
1111
let localBetaGroups = [
12-
generateGroup(id: nil, name: "group to create", publicLinkEnabled: true),
13-
generateGroup(id: "1002", name: "group to update", publicLinkEnabled: false),
12+
BetaGroup(id: nil, name: "group to create", publicLinkEnabled: true),
13+
BetaGroup(id: "1002", name: "group to update", publicLinkEnabled: false),
1414
]
1515

1616
let serverBetaGroups = [
17-
generateGroup(id: "1002", name: "group to update", publicLinkEnabled: true),
18-
generateGroup(id: "1003", name: "group to delete", publicLinkEnabled: true),
17+
BetaGroup(id: "1002", name: "group to update", publicLinkEnabled: true),
18+
BetaGroup(id: "1003", name: "group to delete", publicLinkEnabled: true),
1919
]
2020

2121
let strategies = SyncResourceComparator(
@@ -39,13 +39,16 @@ final class ResourceComparatorCompareGroupsTests: XCTestCase {
3939
}))
4040
}
4141

42-
private func generateGroup(
42+
}
43+
44+
private extension BetaGroup {
45+
init(
4346
id: String?,
4447
name: String,
4548
publicLinkEnabled: Bool = true,
4649
publicLinkLimitEnabled: Bool = true
47-
) -> BetaGroup {
48-
BetaGroup(
50+
) {
51+
self = BetaGroup(
4952
id: id,
5053
groupName: name,
5154
isInternal: true,
@@ -57,5 +60,4 @@ final class ResourceComparatorCompareGroupsTests: XCTestCase {
5760
testers: []
5861
)
5962
}
60-
6163
}

Tests/appstoreconnect-cliTests/Sync/ResourceComparatorCompareTestersTests.swift

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,11 @@ final class ResourceComparatorCompareTestersTests: XCTestCase {
1212
BetaTester(
1313
email: "foo@gmail.com",
1414
firstName: nil,
15-
lastName: nil,
16-
inviteType: nil),
15+
lastName: nil),
1716
BetaTester(
1817
email: "bar@gmail.com",
1918
firstName: nil,
20-
lastName: nil,
21-
inviteType: nil),
19+
lastName: nil),
2220
]
2321

2422
let localTesters: [BetaTester] = []
@@ -62,20 +60,4 @@ final class ResourceComparatorCompareTestersTests: XCTestCase {
6260
}))
6361
}
6462

65-
private func generateGroupWithTesters(
66-
emails: [String]
67-
) -> BetaGroup {
68-
BetaGroup(
69-
id: "0001",
70-
groupName: name,
71-
isInternal: true,
72-
publicLink: "",
73-
publicLinkEnabled: true,
74-
publicLinkLimit: 10,
75-
publicLinkLimitEnabled: true,
76-
creationDate: "",
77-
testers: emails
78-
)
79-
}
80-
8163
}

0 commit comments

Comments
 (0)