Skip to content

Expose and document IPv6 port 19133 by default#626

Merged
itzg merged 3 commits into
itzg:masterfrom
poeggi:master
May 1, 2026
Merged

Expose and document IPv6 port 19133 by default#626
itzg merged 3 commits into
itzg:masterfrom
poeggi:master

Conversation

@poeggi
Copy link
Copy Markdown
Contributor

@poeggi poeggi commented Apr 29, 2026

No description provided.

Copy link
Copy Markdown
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. Just a couple spots to dial it back.

On my Java edition image I am trying to move away from full command-line snippets. They're distracting and harder to maintain. These really need to change to my dual example style like

https://docker-minecraft-server.readthedocs.io/en/latest/configuration/jvm-options/#memory-limit

Comment thread README.md Outdated
Comment thread README.md Outdated
docker run -d -it --name bds-flat-creative \
-e EULA=TRUE -e LEVEL_TYPE=flat -e GAMEMODE=creative \
-p 19132:19132/udp itzg/minecraft-bedrock-server
-p 19132:19132/udp -p 19133:19133/udp itzg/minecraft-bedrock-server
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this. I shouldn't have even included the full command line including any mention of ports.

Copy link
Copy Markdown
Contributor Author

@poeggi poeggi Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted. Please let me know if instead I should remove the -p flag altogether (which I understand would leave us with an unreachable server) -> so a -p in the example makes sense, to not create confusion maybe?

Comment thread README.md Outdated
```shell
docker volume create mc-volume
docker run -d -it --name mc-server -e EULA=TRUE -p 19132:19132/udp -v mc-volume:/data itzg/minecraft-bedrock-server
docker run -d -it --name mc-server -e EULA=TRUE -p 19132:19132/udp -p 19133:19133/udp -v mc-volume:/data itzg/minecraft-bedrock-server
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, remove this change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted, same question as above.

@poeggi
Copy link
Copy Markdown
Contributor Author

poeggi commented Apr 30, 2026

Hope to have addressed the issues the way you feel appropriate.

That said, allow me the comment, I feel in general dual-stack actually is the more common setup in networks these days, not IPv4 only. But I understand you want to keep the examples streamlined.

@poeggi poeggi requested a review from itzg April 30, 2026 16:34
@itzg
Copy link
Copy Markdown
Owner

itzg commented Apr 30, 2026

Good point that most people actually would be dual stack (without knowing it).

Copy link
Copy Markdown
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup

@itzg itzg merged commit 09b8859 into itzg:master May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants