paper: Fix boolean flag always return true#4134
Merged
Merged
Conversation
Test operator when passed in a string checks if the string is not empty, it does not check the expression inside, e.g. [[ "false" ]] returns true because the string is non-empty. Replace test operator with isTrue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in the
scripts/start-deployPaperscriptWhen checking if we pass the
--clean-librariesflag, we check if the var$CLEAN_SERVER_LIBRARIESis setPreviously this was checked by
However performing the test operator
[[on a variable will only return false if the variable is empty, not if it is "false". e.g.Fix replaces test operator with
isTrue $CLEAN_SERVER_LIBRARIES, utilising isTrue function fromscripts/start-utils