Conversation
Owner
Author
|
Сергей, добрый вечер! |
Ivanov-s-tmn
left a comment
Ivanov-s-tmn
left a comment
There was a problem hiding this comment.
Добавь основной сервис, пока он будет пустым, но он уже должен подниматься (pom.xml описывающий сборку основного сервиса, на данном этапе должен содержать только указание на родительский модуль и идентификатор артефакта)
| private final StatsService statsService; | ||
|
|
||
| @PostMapping("/hit") | ||
| public ResponseEntity<Void> hit(@Valid @RequestBody EndpointHit hit) { |
There was a problem hiding this comment.
В этой дтошке нет валидации, стоит добавить
Comment on lines
+22
to
+26
| HitEntity entity = new HitEntity(); | ||
| entity.setApp(hit.getApp()); | ||
| entity.setUri(hit.getUri()); | ||
| entity.setIp(hit.getIp()); | ||
| entity.setTimestamp(hit.getTimestamp()); |
There was a problem hiding this comment.
Вынеси преобразование из дто в энтити в маппер
| } | ||
|
|
||
| public List<ViewStats> getStats(LocalDateTime start, LocalDateTime end, List<String> uris, boolean unique) { | ||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"); |
Comment on lines
26
to
28
| <module>statistics/dto</module> | ||
| <module>statistics/client</module> | ||
| <module>statistics/server</module> |
There was a problem hiding this comment.
Для сервиса статистики тут достаточно указать один модуль (основной pom.xml сервиса статистики), его подмодули уже будут описаны в помнике сервиса
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.