Marks 2026 07 comments#25
Open
msdemlei wants to merge 4 commits into
Open
Conversation
mbtaylor
requested changes
Jul 15, 2026
mbtaylor
left a comment
mbtaylor
left a comment
Member
There was a problem hiding this comment.
Thanks Markus, all fine except one thing: the km/sec unit in the example from Section 2 still needs fixing. You changed the content of ./samples/catalogservice.xml, but the \lstinputlisting that pulls this content in uses ./ipac-resource.xml instead.
I'm using the opportunity to drop the extendedtable example (which was afflicted as well). The technique hasn't been used so far, and what was examined in the example is now done by TAPRegExt. Using this opportunity to run new-release.
I don't think there have ever been records using this type, and I can't remember why I would have postpone dropping the type.
msdemlei
force-pushed
the
marks-2026-07-comments
branch
from
July 16, 2026 11:33
b4b5955 to
63f665e
Compare
mbtaylor
approved these changes
Jul 16, 2026
Collaborator
Author
|
On Wed, Jul 15, 2026 at 08:07:00AM -0700, Mark Taylor wrote:
@mbtaylor requested changes on this pull request.
Thanks Markus, all fine except one thing: the km/sec unit in the
example from Section 2 still needs fixing. You changed the content
of `./samples/catalogservice.xml`, but the `\lstinputlisting` that
pulls this content in uses `./ipac-resource.xml` instead.
Ah. I should have looked more carefully, and we should probably
validate ipac-resource.xml, too. But I've had enough rebasing
excitement for today. So: Is it fine now?
|
Member
|
Yes, I've given it an Approve review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are several fairly independent commits in response to http://mail.ivoa.net/pipermail/registry/2026-July/005666.html; see my mail there for more comments.
I think this should be merged by rebasing to preserve the individual commits in the main history.