Fix image crop modal failing to show#2118
Open
gaearon wants to merge 1 commit intoivpusic:masterfrom
Open
Conversation
This was referenced Dec 19, 2024
|
I tried this fix and it works on iPhone 15 pro & iPhone 8 plus, but for some reason on iPhone 7 not. |
|
We were getting this issue when we upgraded from Expo 51 (RN 0.74) to Expo 52 (RN 0.76). We created a patch based on this PR and that fixed it for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1631
If the controller is being dismissed, we shouldn't be presenting from that controller.
Test Plan
No longer getting
when trying to present the cropper right after the Expo image picker.
See the video in bluesky-social/social-app#7194 to show the interaction. Before the fix, we were getting that log and the cropper would not show up.