feat(find): add JACK find_package module#61
Open
bruxisma wants to merge 4 commits into
Open
Conversation
We can now find the JACK2 libraries as a dependency. Signed-off-by: Izzy Muerte <63051+bruxisma@users.noreply.github.com>
Signed-off-by: Izzy Muerte <63051+bruxisma@users.noreply.github.com>
bruxisma
changed the title
Signed-off-by: Izzy Muerte <63051+bruxisma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings several important fixes in addition to the new feature:
HEADERargument fails in all cases where the directory location and package share the same name.It is unfortunate that the JACK2 interface, library, and packages are so confusing between Windows and Linux. Very little effort has been done to make it clear that the jack2 API is hidden behind packages like
jackd, which have nothing to do withlibjack-dev.Thankfully, it seems we're "one of the first" in this space, as there are effectively no FindJACK2.cmake files on github, and the ones that are provide a simplistic API that will not eventually support: