Skip to content

Commit cc78d1f

Browse files
authored
Update version to 1.3.1 (#440)
Adding scripts to help with versioning - Issue #439
1 parent f9e279c commit cc78d1f

10 files changed

Lines changed: 519 additions & 23 deletions

File tree

README.md

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,40 @@ To see the current version of MetaData used by this library, check the commit co
237237
#### Optional Validation: Cocoapods
238238
1. `cd` into the `libPhoneNumber-Demo` directory
239239
2. Verify the `Podfile` is pointing to the local copies of the pods (using `:path => '../'`)
240-
2. Run `pod install`
241-
3. Open the `libPhoneNumber-Demo` project in Xcode
242-
4. Run the demo project validating phonenumber formatting works as expected
240+
3. Run `pod install`
241+
4. Open the `libPhoneNumber-Demo` project in Xcode
242+
5. Run the demo project validating phonenumber formatting works as expected
243243
244244
245245
#### Optional Validation: Swift Package Manager
246246
1. Open the `libPhoneNumber-Demo-SPM` project in Xcode
247247
2. Verify the `libPhoneNumber` package is using the `local` version
248-
2. Run the demo project validating phonenumber formatting works as expected
248+
3. Run the demo project validating phonenumber formatting works as expected
249+
4. Change the `libPhoneNumber` to use the `remote` version (will need to point at the branch)
250+
5. Build the demo project validating everything builds successfully
251+
* Can also run the demo, but validating successful build will probably provide all the necessary value
252+
253+
### Creating A New Version
254+
255+
1. Determine what the next version should be based on whether the release is:
256+
* JUST Bug fixes - increase the 3rd digit - 1.2.0 --> 1.2.1
257+
* Updated Metadata or added functionality - increase the "minor version" - 1.1.0 --> 1.2.0
258+
* Major changes, possibly non-passive - increase the "major version" - 1.5.0 --> 2.0.0
259+
260+
2. Use the script (in the `scripts` folder) - `versionCommitter.swift`.
261+
262+
Pass the new version into the script and push it to the proper remote repo to create a pull request
263+
264+
scripts/versionCommitter.swift 2.2.4 --push --remote myOrigin
265+
266+
3. Lint the cocoapod
267+
268+
pod lib lint libPhoneNumber-iOS.podspec
269+
270+
4. Create a pull request for the created branch (ex: `Version-2.2.4`)
271+
5. Create a draft release in github describing the changes
272+
6. Try to get at least 2 approvals on the pull request
273+
7. Pull in pull request onto master
274+
8. Push the podspec
275+
276+
pod trunk push libPhoneNumber-iOS.podspec

libPhoneNumber-Demo/libPhoneNumber-Demo-SPM.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@
270270
CLANG_WARN_UNREACHABLE_CODE = YES;
271271
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
272272
COPY_PHASE_STRIP = NO;
273-
CURRENT_PROJECT_VERSION = 1.3.0;
273+
CURRENT_PROJECT_VERSION = 1.3.1;
274274
DEBUG_INFORMATION_FORMAT = dwarf;
275275
ENABLE_STRICT_OBJC_MSGSEND = YES;
276276
ENABLE_TESTABILITY = YES;
@@ -288,7 +288,7 @@
288288
GCC_WARN_UNUSED_FUNCTION = YES;
289289
GCC_WARN_UNUSED_VARIABLE = YES;
290290
IPHONEOS_DEPLOYMENT_TARGET = 13.5;
291-
MARKETING_VERSION = 1.3.0;
291+
MARKETING_VERSION = 1.3.1;
292292
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
293293
MTL_FAST_MATH = YES;
294294
ONLY_ACTIVE_ARCH = YES;
@@ -326,7 +326,7 @@
326326
CLANG_WARN_UNREACHABLE_CODE = YES;
327327
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
328328
COPY_PHASE_STRIP = NO;
329-
CURRENT_PROJECT_VERSION = 1.3.0;
329+
CURRENT_PROJECT_VERSION = 1.3.1;
330330
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
331331
ENABLE_NS_ASSERTIONS = NO;
332332
ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -338,7 +338,7 @@
338338
GCC_WARN_UNUSED_FUNCTION = YES;
339339
GCC_WARN_UNUSED_VARIABLE = YES;
340340
IPHONEOS_DEPLOYMENT_TARGET = 13.5;
341-
MARKETING_VERSION = 1.3.0;
341+
MARKETING_VERSION = 1.3.1;
342342
MTL_ENABLE_DEBUG_INFO = NO;
343343
MTL_FAST_MATH = YES;
344344
SDKROOT = iphoneos;

libPhoneNumber-Demo/libPhoneNumber-Demo.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@
306306
CLANG_WARN_UNREACHABLE_CODE = YES;
307307
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
308308
COPY_PHASE_STRIP = NO;
309-
CURRENT_PROJECT_VERSION = 1.3.0;
309+
CURRENT_PROJECT_VERSION = 1.3.1;
310310
DEBUG_INFORMATION_FORMAT = dwarf;
311311
ENABLE_STRICT_OBJC_MSGSEND = YES;
312312
ENABLE_TESTABILITY = YES;
@@ -324,7 +324,7 @@
324324
GCC_WARN_UNUSED_FUNCTION = YES;
325325
GCC_WARN_UNUSED_VARIABLE = YES;
326326
IPHONEOS_DEPLOYMENT_TARGET = 13.5;
327-
MARKETING_VERSION = 1.3.0;
327+
MARKETING_VERSION = 1.3.1;
328328
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
329329
MTL_FAST_MATH = YES;
330330
ONLY_ACTIVE_ARCH = YES;
@@ -363,7 +363,7 @@
363363
CLANG_WARN_UNREACHABLE_CODE = YES;
364364
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
365365
COPY_PHASE_STRIP = NO;
366-
CURRENT_PROJECT_VERSION = 1.3.0;
366+
CURRENT_PROJECT_VERSION = 1.3.1;
367367
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
368368
ENABLE_NS_ASSERTIONS = NO;
369369
ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -375,7 +375,7 @@
375375
GCC_WARN_UNUSED_FUNCTION = YES;
376376
GCC_WARN_UNUSED_VARIABLE = YES;
377377
IPHONEOS_DEPLOYMENT_TARGET = 13.5;
378-
MARKETING_VERSION = 1.3.0;
378+
MARKETING_VERSION = 1.3.1;
379379
MTL_ENABLE_DEBUG_INFO = NO;
380380
MTL_FAST_MATH = YES;
381381
SDKROOT = iphoneos;

libPhoneNumber-GeocodingParser/libPhoneNumber-GeocodingParser.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@
315315
CLANG_WARN_UNREACHABLE_CODE = YES;
316316
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
317317
COPY_PHASE_STRIP = NO;
318-
CURRENT_PROJECT_VERSION = 1.3.0;
318+
CURRENT_PROJECT_VERSION = 1.3.1;
319319
DEAD_CODE_STRIPPING = YES;
320320
DEBUG_INFORMATION_FORMAT = dwarf;
321321
ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -334,7 +334,7 @@
334334
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
335335
GCC_WARN_UNUSED_FUNCTION = YES;
336336
GCC_WARN_UNUSED_VARIABLE = YES;
337-
MARKETING_VERSION = 1.3.0;
337+
MARKETING_VERSION = 1.3.1;
338338
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
339339
MTL_FAST_MATH = YES;
340340
ONLY_ACTIVE_ARCH = YES;
@@ -376,7 +376,7 @@
376376
CLANG_WARN_UNREACHABLE_CODE = YES;
377377
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
378378
COPY_PHASE_STRIP = NO;
379-
CURRENT_PROJECT_VERSION = 1.3.0;
379+
CURRENT_PROJECT_VERSION = 1.3.1;
380380
DEAD_CODE_STRIPPING = YES;
381381
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
382382
ENABLE_NS_ASSERTIONS = NO;
@@ -389,7 +389,7 @@
389389
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
390390
GCC_WARN_UNUSED_FUNCTION = YES;
391391
GCC_WARN_UNUSED_VARIABLE = YES;
392-
MARKETING_VERSION = 1.3.0;
392+
MARKETING_VERSION = 1.3.1;
393393
MTL_ENABLE_DEBUG_INFO = NO;
394394
MTL_FAST_MATH = YES;
395395
SDKROOT = macosx;

libPhoneNumber-iOS.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "libPhoneNumber-iOS"
3-
s.version = "1.3.0"
3+
s.version = "1.3.1"
44
s.summary = "iOS library for parsing, formatting, storing and validating international phone numbers from libphonenumber library."
55
s.description = "libPhoneNumber for iOS. iOS library for parsing, formatting, storing and validating international phone numbers from libphonenumber library."
66
s.homepage = "https://github.com/iziz/libPhoneNumber-iOS.git"

libPhoneNumber.xcodeproj/project.pbxproj

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,8 @@
213213
BB9B60432EBE9A0500C48233 /* _HeaderOnlyShim.c */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.c; path = _HeaderOnlyShim.c; sourceTree = "<group>"; };
214214
BB9B60442EBE9A0500C48233 /* GeocodingMetaData.bundle */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.plug-in"; path = GeocodingMetaData.bundle; sourceTree = "<group>"; };
215215
BB9B60492EBE9A7800C48233 /* libPhoneNumber.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = libPhoneNumber.h; sourceTree = "<group>"; };
216+
BBCABBF32EE0E61E0011A4C7 /* updateProjectVersions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = updateProjectVersions.swift; sourceTree = "<group>"; };
217+
BBCABBF52EE0F6E90011A4C7 /* versionCommitter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = versionCommitter.swift; sourceTree = "<group>"; };
216218
BBF66CA82EBBF9B9005E3382 /* NBGeneratedPhoneNumberMetaData.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = NBGeneratedPhoneNumberMetaData.m; sourceTree = "<group>"; };
217219
BBF66CAA2EBBF9E2005E3382 /* NBGeneratedShortNumberMetaData.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = NBGeneratedShortNumberMetaData.m; sourceTree = "<group>"; };
218220
BBF66CAC2EBC0783005E3382 /* NSBundle+Extensions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "NSBundle+Extensions.h"; sourceTree = "<group>"; };
@@ -371,6 +373,8 @@
371373
children = (
372374
BB23C3BB2EB9628D00A94F44 /* GeneratePhoneNumberMetaDataFiles.sh */,
373375
BB23C3BC2EB9628D00A94F44 /* metadataGenerator.swift */,
376+
BBCABBF32EE0E61E0011A4C7 /* updateProjectVersions.swift */,
377+
BBCABBF52EE0F6E90011A4C7 /* versionCommitter.swift */,
374378
);
375379
path = scripts;
376380
sourceTree = "<group>";
@@ -1392,7 +1396,7 @@
13921396
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
13931397
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
13941398
COPY_PHASE_STRIP = NO;
1395-
CURRENT_PROJECT_VERSION = 1.3.0;
1399+
CURRENT_PROJECT_VERSION = 1.3.1;
13961400
ENABLE_STRICT_OBJC_MSGSEND = YES;
13971401
ENABLE_TESTABILITY = YES;
13981402
GCC_C_LANGUAGE_STANDARD = gnu99;
@@ -1414,7 +1418,7 @@
14141418
GCC_WARN_UNUSED_VARIABLE = YES;
14151419
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
14161420
MACOSX_DEPLOYMENT_TARGET = 10.13;
1417-
MARKETING_VERSION = 1.3.0;
1421+
MARKETING_VERSION = 1.3.1;
14181422
ONLY_ACTIVE_ARCH = YES;
14191423
OTHER_CFLAGS = "";
14201424
SDKROOT = iphoneos;
@@ -1454,7 +1458,7 @@
14541458
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
14551459
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
14561460
COPY_PHASE_STRIP = YES;
1457-
CURRENT_PROJECT_VERSION = 1.3.0;
1461+
CURRENT_PROJECT_VERSION = 1.3.1;
14581462
ENABLE_STRICT_OBJC_MSGSEND = YES;
14591463
GCC_C_LANGUAGE_STANDARD = gnu99;
14601464
GCC_GENERATE_TEST_COVERAGE_FILES = YES;
@@ -1468,7 +1472,7 @@
14681472
GCC_WARN_UNUSED_VARIABLE = YES;
14691473
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
14701474
MACOSX_DEPLOYMENT_TARGET = 10.13;
1471-
MARKETING_VERSION = 1.3.0;
1475+
MARKETING_VERSION = 1.3.1;
14721476
OTHER_CFLAGS = "";
14731477
SDKROOT = iphoneos;
14741478
SWIFT_COMPILATION_MODE = wholemodule;

libPhoneNumberGeocoding.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "libPhoneNumberGeocoding"
3-
s.version = "1.3.0"
3+
s.version = "1.3.1"
44
s.summary = "Geocoding Features for libPhoneNumber-iOS"
55
s.description = "libPhoneNumberGeocoding for iOS. iOS library for gathering region descriptions for any phone number. This library stores geocoding metadata on disk space."
66
s.homepage = "https://github.com/iziz/libPhoneNumber-iOS.git"

libPhoneNumberShortNumber.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "libPhoneNumberShortNumber"
3-
s.version = "1.3.0"
3+
s.version = "1.3.1"
44
s.summary = "Short Number Support for libPhoneNumber-iOS"
55
s.description = "libPhoneNumberShortNumber for iOS. iOS library for implementing libPhoneNumber features on short numbers."
66
s.homepage = "https://github.com/iziz/libPhoneNumber-iOS.git"

0 commit comments

Comments
 (0)