Skip to content

Commit 00c7dc0

Browse files
committed
Fix VSIX verification to use unzip instead of vsce ls
vsce ls does not support --packagePath. Use unzip -l to check whether bin/git-crypt is present in platform-specific packages and absent from the universal package.
1 parent 90ebc89 commit 00c7dc0

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,15 @@ jobs:
152152
run: |
153153
for f in git-crypt-vscode-*-*.vsix; do
154154
echo "=== $f ==="
155-
npx vsce ls --packagePath "$f" | grep -c 'bin/git-crypt' | xargs -I{} test {} -eq 1
155+
unzip -l "$f" | grep -q 'bin/git-crypt' || { echo "FAIL: bin/git-crypt missing from $f"; exit 1; }
156156
done
157157
echo "=== universal ==="
158158
UNIVERSAL=$(ls git-crypt-vscode-*.vsix | grep -v -- '-darwin\|-linux')
159-
npx vsce ls --packagePath "$UNIVERSAL" | grep -c 'bin/git-crypt' | xargs -I{} test {} -eq 0
159+
if unzip -l "$UNIVERSAL" | grep -q 'bin/git-crypt'; then
160+
echo "FAIL: bin/git-crypt should not be in universal $UNIVERSAL"
161+
exit 1
162+
fi
163+
echo "All VSIX contents verified"
160164
161165
- name: Create or update GitHub release
162166
if: startsWith(github.ref, 'refs/tags/v')

0 commit comments

Comments
 (0)