Skip to content

Commit b6e6350

Browse files
committed
Exclude artifacts/ from VSIX packages
- .vscodeignore: add artifacts/ so vsce package does not bundle the CI download-artifact directory (all platform binaries were leaking into every platform-specific VSIX) - ci.yml: verify step now fails if artifacts/ appears in any VSIX
1 parent 20e8603 commit b6e6350

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,13 +158,21 @@ jobs:
158158
for f in git-crypt-vscode-*-*.vsix; do
159159
echo "=== $f ==="
160160
unzip -l "$f" | grep -q 'bin/git-crypt' || { echo "FAIL: bin/git-crypt missing from $f"; exit 1; }
161+
if unzip -l "$f" | grep -q 'artifacts/'; then
162+
echo "FAIL: artifacts/ should not be in $f"
163+
exit 1
164+
fi
161165
done
162166
echo "=== universal ==="
163167
UNIVERSAL=$(ls git-crypt-vscode-*.vsix | grep -v -- '-darwin\|-linux')
164168
if unzip -l "$UNIVERSAL" | grep -q 'bin/git-crypt'; then
165169
echo "FAIL: bin/git-crypt should not be in universal $UNIVERSAL"
166170
exit 1
167171
fi
172+
if unzip -l "$UNIVERSAL" | grep -q 'artifacts/'; then
173+
echo "FAIL: artifacts/ should not be in universal $UNIVERSAL"
174+
exit 1
175+
fi
168176
echo "All VSIX contents verified"
169177
170178
- name: Create or update GitHub release

.vscodeignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.claude/
22
.github/
33
.gitignore
4+
artifacts/
45
.vsixignore
56
CLAUDE.md
67
CONTRIBUTING.md

0 commit comments

Comments
 (0)