Skip to content

Commit 6fec9cd

Browse files
committed
docs: changelog entry for this branch's fixes
Summarize the user-visible changes from the multi-agent review pass: new test suite, settings-corruption + NPE + CQRS over-reporting + missing gutter icons + dumb-mode guard regressions. https://claude.ai/code/session_01SKogXRGoKRw1AV4SpzUTW6
1 parent dcdd314 commit 6fec9cd

1 file changed

Lines changed: 18 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,21 @@
22

33
# spiral-plugin Changelog
44

5+
## [Unreleased]
6+
7+
### Added
8+
- Test suite covering indexes, references, line markers, folding, and run-configuration settings (30 new test classes; full `gradle test` is now meaningful).
9+
- `com.intellij.modules.json` added to `platformBundledPlugins` so the PHP plugin loads in the test sandbox (was the root cause of an empty effective extension set).
10+
- `VIEWS_RENDER_SIGNATURE` and `ENV_FUNCTION` / `AUTOWIRE` constants in `SpiralFrameworkClasses` — replaces hardcoded FQNs scattered across `ViewReferenceContributor`, `EnvFoldingBuilder`, and `ContainerReferenceContributor`.
11+
12+
### Fixed
13+
- **Run-configuration settings corruption**`SpiralConsoleCommandRunConfigurationSettings` aliased `workingDirectory` and `documentRoot` onto the `binary` XML attribute. Each property now persists under its own slot; existing saved configurations migrate cleanly.
14+
- **`ObjectStreamDataExternalizer.read` NPE** on null payloads — cast widened from `as T` to `as T?` so callers can decide how to handle null.
15+
- **CQRS implicit usage over-reporting**`CqrsHandlersImplicitUsageProvider.isClassWithCustomizedInitialization` returned `true` unconditionally, marking every PHP class as having customized init.
16+
- **CQRS gutter icons missing**`CqrsHandlersLineMarkerProvider.getLineMarkerInfo` matched on `PhpClass`, but the platform calls line markers on leaf elements only; re-anchored to the class-name identifier.
17+
- **Dumb-mode crashes** at three call sites that query `PrototypedIndex` / `CqrsIndexUtil` without `DumbService` guarding — `PrototypedCompletion`, `CqrsHandlersLineMarkerProvider`, and `PrototypedPropertyReference` now early-return while indexing.
18+
19+
### Changed
20+
- `gradle.properties` `platformBundledPlugins` extended with the PHP plugin's transitive `com.intellij.modules.json` requirement.
21+
- Folding placeholder for `env('KEY')` calls uses the central `SpiralFrameworkClasses.ENV_FUNCTION` constant.
22+

0 commit comments

Comments
 (0)