Commit dcdd314
committed
fix: guard 3 index call sites against dumb mode
Code review (5 finder angles + 1-vote verification) flagged three
call sites that consume PrototypedIndex / CqrsIndexUtil without the
dumb-mode wrapper their own KDoc/contract requires:
- prototyped/PrototypedCompletion.kt:46 — completion popup at a
PrototypeTrait site during indexing would throw
IndexNotReadyException.
- cqrs/CqrsHandlersLineMarkerProvider.kt:30 — gutter pass over a
Command/Query class during indexing would crash and silently drop
every CQRS line marker.
- prototyped/PrototypedPropertyReference.kt:29 — getVariants() called
during indexing would crash completion.
Fix: early-return when DumbService.isDumb(project), so the IDE simply
shows no result until indexes are ready, instead of erroring.
./gradlew test -x patchPluginXml: 76/76 passing, exit 0.
https://claude.ai/code/session_01SKogXRGoKRw1AV4SpzUTW61 parent 2331e78 commit dcdd314
3 files changed
Lines changed: 8 additions & 2 deletions
File tree
- src/main/kotlin/com/github/xepozz/spiral
- cqrs
- prototyped
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| 43 | + | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | | - | |
30 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
0 commit comments