fix: harden version detection, config-type id, command-run executor, coverage error

- TestoVersionDetector.parse: reject output without the 'Testo ' prefix
  (substringAfter now uses missingDelimiterValue "") instead of returning it as
  a version; updated TestoVersionDetectorTest to the corrected contract.
- TestoRunConfigurationType.ID: pin the literal "TestoRunConfiguration" so a class
  rename can't silently break persisted run configs.
- TestoRunCommandAction: run via DefaultRunExecutor instead of the order-dependent
  EXECUTOR_EXTENSION_NAME.extensionList.first().
- Coverage: throw RuntimeConfigurationError (not IllegalArgumentException) for an
  unsupported engine.

Author: xepozz

src/main/kotlin/com/github/xepozz/testo/coverage/TestoCoverageProgramRunner.kt

@@ -2,6 +2,7 @@ package com.github.xepozz.testo.coverage
 
 import com.github.xepozz.testo.tests.run.TestoRunConfiguration
 import com.intellij.execution.configurations.RunProfile
+import com.intellij.execution.configurations.RuntimeConfigurationError
 import com.intellij.execution.configurations.RunProfileState
 import com.intellij.execution.runners.ExecutionEnvironment
 import com.jetbrains.php.config.commandLine.PhpCommandSettings
@@ -75,7 +76,7 @@ open class TestoCoverageProgramRunner : PhpCoverageRunner() {
                 .createXdebugConfigurations()
 
             CoverageEngine.PCOV -> listOf(PhpConfigurationOption("pcov.enabled", 1))
-            else -> throw IllegalArgumentException("Unsupported coverage engine $coverageEngine.")
+            else -> throw RuntimeConfigurationError("Unsupported Testo coverage engine: $coverageEngine.")
         }
         command.addConfigurationOptions(options)
         setAdditionalMapping(localCoverage, targetCoverage, command)

src/main/kotlin/com/github/xepozz/testo/tests/TestoVersionDetector.kt

@@ -10,7 +10,7 @@ object TestoVersionDetector : PhpTestFrameworkVersionDetector<String>() {
     public override fun getVersionOptions() = arrayOf("--version", "--no-ansi")
 
     public override fun parse(s: String): String {
-        val version = s.substringAfter("Testo ")
+        val version = s.substringAfter("Testo ", "")  // "" on miss so non-Testo output is rejected below
         if (version.isEmpty()) {
             throw ExecutionException(TestoBundle.message("testo.version.error"))
         }

src/main/kotlin/com/github/xepozz/testo/tests/actions/TestoRunCommandAction.kt

@@ -4,7 +4,7 @@ import com.github.xepozz.testo.TestoBundle
 import com.github.xepozz.testo.TestoIcons
 import com.github.xepozz.testo.tests.run.TestoRunConfiguration
 import com.github.xepozz.testo.tests.run.TestoRunConfigurationProducer
-import com.intellij.execution.Executor
+import com.intellij.execution.executors.DefaultRunExecutor
 import com.intellij.execution.RunManagerEx
 import com.intellij.execution.runners.ExecutionUtil
 import com.intellij.openapi.actionSystem.AnAction
@@ -34,6 +34,6 @@ class TestoRunCommandAction(val commandName: String) : AnAction() {
         val configuration = runManager.createConfiguration(runConfiguration, configurationFactory)
 
         runManager.setTemporaryConfiguration(configuration)
-        ExecutionUtil.runConfiguration(configuration, Executor.EXECUTOR_EXTENSION_NAME.extensionList.first())
+        ExecutionUtil.runConfiguration(configuration, DefaultRunExecutor.getRunExecutorInstance())
     }
 }

src/main/kotlin/com/github/xepozz/testo/tests/run/TestoRunConfigurationType.kt

@@ -18,7 +18,9 @@ class TestoRunConfigurationType :
         TestoRunConfiguration(project, this)
 
     companion object Companion {
-        val ID = TestoRunConfiguration::class.java.simpleName
+        // Pinned literal (was ::class.simpleName): a future class rename must not silently change the
+        // persisted run-configuration type id and break users' saved configs.
+        const val ID = "TestoRunConfiguration"
 
         val INSTANCE
             get() = findConfigurationType(TestoRunConfigurationType::class.java)

src/test/kotlin/com/github/xepozz/testo/TestoVersionDetectorTest.kt

@@ -24,8 +24,13 @@ class TestoVersionDetectorTest : TestCase() {
     }
 
     fun testParse_noPrefix() {
-        // "substringAfter" returns original string if delimiter not found
-        assertEquals("SomeOtherOutput", TestoVersionDetector.parse("SomeOtherOutput"))
+        // Output without the "Testo " prefix is not a version and must be rejected (previously it leaked through).
+        try {
+            TestoVersionDetector.parse("SomeOtherOutput")
+            fail("Expected ExecutionException for non-Testo output")
+        } catch (_: ExecutionException) {
+            // expected
+        }
     }
 
     fun testGetVersionOptions() {