Slight adjustment to the interface#33
Conversation
Make the the following tk widgets take all available horizontal space within their parent and expand with the application window: - .vpane.lower.commarea.buffer - .vpane.lower.commarea.buffer.frame - .vpane.lower.commarea.buffer.frame.t (via ui_comm variable) This allows the commit message editor along with its widgets reflow This is visually better on very wide monitors plus it is the same behavior as the widget above Signed-off-by: Alexander Shopov <ash@kambanaria.org>
|
Here is demonstration of the intended behavior: Here is the standard behavior of master And here is the visualization when you resize the app window with the patch applied |
|
This change is not desirable in this form. The Options dialog has a setting for the width of the commit message area in characters. This width must be obeyed. I can imagine that we reserve a special value, say |
|
Concerning the commit itself, please be more specific in the title and follow the usual style, in particular, the "git-gui:" prefix. In the body, it is not necessary to call out the widget names in the code, but rather tell what they are ("the commit message field and ..."). |
|
@j6t: thanx for the feedback. I will do one more round of improvements. I will probably bounce the patch off the mailing list once I handle your comments. |
2 participants
Make the the following tk widgets take all available horizontal space within their parent and expand with the application window:
This allows the commit message editor along with its widgets reflow This is visually better on very wide monitors plus it is the same behavior as the widget above