GLES and Android backend improvements and fixup (#2727)

* android fixup

Co-authored-by: Copilot <copilot@github.com>

* fix build

* fixes

Co-authored-by: Copilot <copilot@github.com>

* better best depth format detection

Co-authored-by: Copilot <copilot@github.com>

* fixes and cleanup

* support examples autorun

Co-authored-by: Copilot <copilot@github.com>

* update screenshots

---------

Co-authored-by: Copilot <copilot@github.com>

Author: riccardobl

README.md

@@ -125,6 +125,18 @@ You can optionally use the `-Pexample` property to specify an example to start w
 ./gradlew runExamples -Pexample=jme3test.light.pbr.TestPBRSimple
 ```
 
+### Android examples
+
+You can run the Android examples on a local android emulator with:
+
+```bash
+./gradlew -PbuildAndroidExamples=true -PbuildNativeProjects=true runAndroidExamples 
+# or for a specific example:
+# ./gradlew -PbuildAndroidExamples=true -PbuildNativeProjects=true runAndroidExamples -Pexample=jme3test.post.TestBloom
+```
+
+*Make sure to have the SDK and NDK installed and configured properly, and the emulator running before executing the command.*
+
 
 ## Running Tests 
 

build.gradle

@@ -182,17 +182,56 @@ task configureAndroidNDK {
         ndkBuildFile = "ndk-build.cmd"
     }
 
-    // ndkPath is defined in the root project gradle.properties file
-    String ndkBuildPath = ndkPath + File.separator + ndkBuildFile
-    //Use the environment variable for the NDK location if defined
-    if (System.env.ANDROID_NDK != null) {
-        ndkBuildPath = System.env.ANDROID_NDK + File.separator + ndkBuildFile
+    def ndkCandidates = []
+    if (System.env.ANDROID_NDK) {
+        ndkCandidates << file(System.env.ANDROID_NDK)
+    }
+    if (System.env.ANDROID_NDK_HOME) {
+        ndkCandidates << file(System.env.ANDROID_NDK_HOME)
+    }
+    if (project.hasProperty('ndkPath') && ndkPath) {
+        ndkCandidates << file(ndkPath)
     }
 
-    if (new File(ndkBuildPath).exists()) {
+    def localProperties = file('local.properties')
+    if (localProperties.isFile()) {
+        Properties properties = new Properties()
+        localProperties.withInputStream { properties.load(it) }
+        if (properties.getProperty('ndk.dir')) {
+            ndkCandidates << file(properties.getProperty('ndk.dir'))
+        }
+        if (properties.getProperty('sdk.dir')) {
+            ndkCandidates.addAll(findAndroidNdkDirs(file(properties.getProperty('sdk.dir'))))
+        }
+    }
+
+    if (System.env.ANDROID_HOME) {
+        ndkCandidates.addAll(findAndroidNdkDirs(file(System.env.ANDROID_HOME)))
+    }
+    if (System.env.ANDROID_SDK_ROOT) {
+        ndkCandidates.addAll(findAndroidNdkDirs(file(System.env.ANDROID_SDK_ROOT)))
+    }
+    ndkCandidates.addAll(findAndroidNdkDirs(file("${System.properties['user.home']}/Android/Sdk")))
+
+    def ndkBuildPath = ndkCandidates.collect { new File(it, ndkBuildFile) }.find { it.isFile() }
+    if (ndkBuildPath != null) {
         ndkExists = true
-        ndkCommandPath = ndkBuildPath
+        ndkCommandPath = ndkBuildPath.absolutePath
+    }
+}
+
+def findAndroidNdkDirs(File sdkDir) {
+    def ndkDirs = []
+    def nestedSdkDir = new File(sdkDir, 'Sdk')
+    if (nestedSdkDir.isDirectory()) {
+        ndkDirs.addAll(findAndroidNdkDirs(nestedSdkDir))
+    }
+    def sideBySideDir = new File(sdkDir, 'ndk')
+    if (sideBySideDir.isDirectory()) {
+        ndkDirs.addAll(sideBySideDir.listFiles()?.findAll { it.isDirectory() }?.sort { a, b -> b.name <=> a.name } ?: [])
     }
+    ndkDirs << new File(sdkDir, 'ndk-bundle')
+    return ndkDirs
 }
 
 gradle.rootProject.ext.set("usePrebuildNatives", buildNativeProjects!="true");

common-android-app.gradle

@@ -6,6 +6,6 @@ version = jmeFullVersion
 repositories {
     mavenCentral()
     maven {
-        url "http://nifty-gui.sourceforge.net/nifty-maven-repo"
+        url "https://nifty-gui.sourceforge.net/nifty-maven-repo"
     }
 }

gradle/jacoco.gradle

@@ -61,7 +61,9 @@ reporting {
 
 def jacocoSubprojects = subprojects.findAll { p ->
     (p.file("src/main/java").exists() || p.file("src/main/groovy").exists()) &&
-    (p.file("src/test/java").exists() || p.file("src/test/groovy").exists())
+    (p.file("src/test/java").exists() || p.file("src/test/groovy").exists()) &&
+    p.tasks.findByName('test') &&
+    p.tasks.findByName('jacocoTestReport')
 }
 
 dependencies {

gradle/libs.versions.toml

@@ -11,9 +11,11 @@ spotbugs = "4.9.8"
 [libraries]
 
 androidx-annotation = "androidx.annotation:annotation:1.7.1"
+androidx-fragment = "androidx.fragment:fragment:1.8.9"
 androidx-lifecycle-common = "androidx.lifecycle:lifecycle-common:2.7.0"
 android-build-gradle = "com.android.tools.build:gradle:9.1.0"
 android-support-appcompat = "com.android.support:appcompat-v7:28.0.0"
+androidx-test-runner = "androidx.test:runner:1.7.0"
 gradle-git = "org.ajoberstar:gradle-git:1.2.0"
 groovy-test = "org.apache.groovy:groovy-test:4.0.31"
 gson = "com.google.code.gson:gson:2.13.2"
@@ -23,6 +25,7 @@ jinput = "net.java.jinput:jinput:2.0.9"
 jna = "net.java.dev.jna:jna:5.18.1"
 jnaerator-runtime = "com.nativelibs4java:jnaerator-runtime:0.12"
 junit-bom = "org.junit:junit-bom:5.13.4"
+junit4 = "junit:junit:4.13.2"
 junit-jupiter = { module = "org.junit.jupiter:junit-jupiter" }
 junit-platform-launcher = { module = "org.junit.platform:junit-platform-launcher" }
 lwjgl2 = "org.jmonkeyengine:lwjgl:2.9.5"

jme3-android-examples/build.gradle

@@ -1,5 +1,7 @@
 apply plugin: 'com.android.application'
 
+def examplesJar = project(':jme3-examples').tasks.named('jar')
+
 android {
     namespace "org.jmonkeyengine.jme3androidexamples"
     compileSdk 34
@@ -16,12 +18,13 @@ android {
         targetSdk 34           // Android 14
         versionCode 1
         versionName "1.0" // TODO: from settings.gradle
+        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
     buildTypes {
         release {
             minifyEnabled false
-            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
+            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
     }
 
@@ -40,23 +43,117 @@ android {
                 srcDir '../jme3-testdata/src/main/resources'
                 srcDir '../jme3-examples/src/main/resources'
             }
+            jniLibs {
+                srcDir '../build/native/openalsoft'
+                srcDir '../build/native/decode'
+                srcDir '../build/native/allocator'
+            }
         }
     }
 }
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
-    testImplementation libs.junit4
-    implementation libs.androidx.appcompat
-
+    testImplementation platform(libs.junit.bom)
+    testImplementation libs.junit.jupiter
+    testRuntimeOnly libs.junit.platform.launcher
+    androidTestImplementation libs.junit4
+    androidTestImplementation libs.androidx.test.runner
+    implementation libs.androidx.fragment
     implementation project(':jme3-core')
     implementation project(':jme3-android')
     implementation project(':jme3-android-native')
     implementation project(':jme3-effects')
     implementation project(':jme3-jbullet')
+    implementation project(':jme3-jogg')
     implementation project(':jme3-networking')
     implementation project(':jme3-niftygui')
     implementation project(':jme3-plugins')
+    implementation project(':jme3-plugins-json')
+    implementation project(':jme3-plugins-json-gson')
     implementation project(':jme3-terrain')
-    implementation fileTree(dir: '../jme3-examples/build/libs', include: ['*.jar'], exclude: ['*sources*.*'])
+    implementation files(examplesJar.flatMap { it.archiveFile })
+}
+
+tasks.named('preBuild') {
+    dependsOn examplesJar
+    if (buildNativeProjects == "true") {
+        dependsOn ':jme3-android-native:updatePreCompiledOpenAlSoftLibs'
+        dependsOn ':jme3-android-native:updatePreCompiledLibs'
+        dependsOn ':jme3-android-native:updatePreCompiledLibsBufferAllocator'
+    } else if (skipPrebuildLibraries != "true") {
+        dependsOn ':jme3-android-native:copyPreCompiledOpenAlSoftLibs'
+        dependsOn ':jme3-android-native:copyPreCompiledLibs'
+        dependsOn ':jme3-android-native:copyPreCompiledLibsBufferAllocator'
+    }
+}
+
+tasks.register('installAndroidExamples', Exec) {
+    group = 'application'
+    description = 'Install the Android examples selector on a connected emulator or device.'
+
+    dependsOn tasks.named('assembleDebug')
+
+    doFirst {
+        def adbExecutable = findAdbExecutable()
+        if (adbExecutable == null) {
+            throw new GradleException("ADB not found. Set -Pandroid.sdk.path, ANDROID_HOME, or ANDROID_SDK_ROOT.")
+        }
+        def apkFile = layout.buildDirectory.file('outputs/apk/debug/jme3-android-examples-debug.apk').get().asFile
+        if (!apkFile.isFile()) {
+            throw new GradleException("Debug APK not found at ${apkFile}.")
+        }
+        executable adbExecutable.absolutePath
+        args 'install', '-r', apkFile.absolutePath
+    }
+}
+
+tasks.register('runAndroidExamples', Exec) {
+    group = 'application'
+    description = 'Install and launch Android examples on a connected emulator or device. Use -Pexample=<class> to run a specific test directly.'
+
+    dependsOn tasks.named('installAndroidExamples')
+
+    doFirst {
+        def adbExecutable = findAdbExecutable()
+        if (adbExecutable == null) {
+            throw new GradleException("ADB not found. Set -Pandroid.sdk.path, ANDROID_HOME, or ANDROID_SDK_ROOT.")
+        }
+        executable adbExecutable.absolutePath
+
+        def exampleClass = project.findProperty('example')?.toString()?.trim()
+        if (exampleClass) {
+            args 'shell', 'am', 'start',
+                    '-n', 'org.jmonkeyengine.jme3androidexamples/.TestActivity',
+                    '--es', 'Selected_App_Class', exampleClass,
+                    '--ez', 'Enable_Mouse_Events', 'true',
+                    '--ez', 'Enable_Joystick_Events', 'false',
+                    '--ez', 'Enable_Key_Events', 'true',
+                    '--ez', 'Verbose_Logging', 'false'
+        } else {
+            args 'shell', 'am', 'start',
+                    '-n', 'org.jmonkeyengine.jme3androidexamples/.MainActivity'
+        }
+    }
+}
+
+def findAdbExecutable() {
+    def adbName = System.properties['os.name'].toLowerCase().contains('windows') ? 'adb.exe' : 'adb'
+    def sdkDirs = []
+    if (project.findProperty('android.sdk.path')) {
+        sdkDirs << file(project.findProperty('android.sdk.path'))
+    }
+    if (System.env.ANDROID_HOME) {
+        sdkDirs << file(System.env.ANDROID_HOME)
+    }
+    if (System.env.ANDROID_SDK_ROOT) {
+        sdkDirs << file(System.env.ANDROID_SDK_ROOT)
+    }
+    sdkDirs << file("${System.properties['user.home']}/Android/Sdk")
+
+    def expandedSdkDirs = sdkDirs.collectMany { sdkDir ->
+        [sdkDir, new File(sdkDir, 'Sdk')]
+    }.unique { it.absolutePath }
+
+    return expandedSdkDirs.collect { new File(new File(it, 'platform-tools'), adbName) }.find { it.isFile() }
 }

jme3-android-examples/src/androidTest/java/org/jmonkeyengine/jme3androidexamples/ApplicationTest.java

@@ -1,13 +1,19 @@
 package org.jmonkeyengine.jme3androidexamples;
 
-import android.app.Application;
-import android.test.ApplicationTestCase;
+import androidx.test.platform.app.InstrumentationRegistry;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 /**
  * <a href="http://d.android.com/tools/testing/testing_android.html">Testing Fundamentals</a>
  */
-public class ApplicationTest extends ApplicationTestCase<Application> {
-    public ApplicationTest() {
-        super(Application.class);
+public class ApplicationTest {
+    @Test
+    public void testApplicationPackage() {
+        String packageName = InstrumentationRegistry.getInstrumentation()
+                .getTargetContext()
+                .getPackageName();
+        assertEquals("org.jmonkeyengine.jme3androidexamples", packageName);
     }
-}
+}

jme3-android-examples/src/main/AndroidManifest.xml

@@ -9,6 +9,7 @@
             android:theme="@style/AppTheme">
         <activity
                 android:name=".MainActivity"
+                android:exported="true"
                 android:label="@string/app_name"
                 android:launchMode="singleTask">
             <intent-filter>
@@ -19,15 +20,16 @@
         </activity>
         <activity
                 android:name=".TestActivity"
+                android:exported="true"
                 android:label="@string/app_name"
                 android:launchMode="singleTask"
                 android:screenOrientation="landscape">
         </activity>
     </application>
 
-    <!-- Tell the system that you need ES 2.0. -->
+    <!-- Tell the system that you need ES 3.0. -->
     <uses-feature
-            android:glEsVersion="0x00020000"
+            android:glEsVersion="0x00030000"
             android:required="true"/>
 
     <!-- Tell the system that you need distinct touches (for the zoom gesture). -->
@@ -41,6 +43,7 @@
             android:normalScreens="true"
             android:smallScreens="true"/>
 
+    <uses-permission android:name="android.permission.INTERNET"/>
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
     <uses-permission android:name="android.permission.READ_PHONE_STATE"/>
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>