An unexpected regression in 3.8.0-stable was just found regarding instancing with the new changes to the PBR shader.
I thought I had tested instancing by running the Intsancing related tests in jme-examples, but it turns out that these all use either Unshaded.j3md or Lighting.j3md and we do not have any instancing tests that use a pbr material. On top of that, I also don't use instancing in my own project yet so I didn't catch this in any of my testing unfortunately.
So It would be useful to create at least 1 new instancing test with PBRLighting.j3md. The existing ones could be used as a possible foundation: https://github.com/search?q=repo%3AjMonkeyEngine%2Fjmonkeyengine+path%3A%2F%5Ejme3-examples%5C%2F%2F+instanced&type=code
An unexpected regression in 3.8.0-stable was just found regarding instancing with the new changes to the PBR shader.
I thought I had tested instancing by running the Intsancing related tests in jme-examples, but it turns out that these all use either Unshaded.j3md or Lighting.j3md and we do not have any instancing tests that use a pbr material. On top of that, I also don't use instancing in my own project yet so I didn't catch this in any of my testing unfortunately.
So It would be useful to create at least 1 new instancing test with PBRLighting.j3md. The existing ones could be used as a possible foundation: https://github.com/search?q=repo%3AjMonkeyEngine%2Fjmonkeyengine+path%3A%2F%5Ejme3-examples%5C%2F%2F+instanced&type=code