Skip to content

jme3-examples: TestReverb code cleanup#2419

Merged
yaRnMcDonuts merged 9 commits into
jMonkeyEngine:masterfrom
capdevon:capdevon-TestReverb
May 10, 2025
Merged

jme3-examples: TestReverb code cleanup#2419
yaRnMcDonuts merged 9 commits into
jMonkeyEngine:masterfrom
capdevon:capdevon-TestReverb

Conversation

@capdevon

@capdevon capdevon commented May 3, 2025

Copy link
Copy Markdown
Contributor

Refactored the TestReverb example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.

Refactored the TestReverb example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.

@codex128 codex128 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@capdevon capdevon changed the title Update TestReverb: code cleanup jme3-examples: TestReverb code cleanup May 3, 2025
@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone May 6, 2025
Added more test Environments and some options to enable/disable the Reverb Filter
@capdevon

capdevon commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

@yaRnMcDonuts Wait a bit before merge this PR, I am using it to test the combined effects of the Environment and Reverb Filters. I will let you know when it is ready ;)

Edit:
image

@capdevon

capdevon commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

@yaRnMcDonuts, the PR is now complete and ready to be merged or reviewed ;)

@yaRnMcDonuts yaRnMcDonuts merged commit b920f8c into jMonkeyEngine:master May 10, 2025
16 checks passed
@capdevon capdevon deleted the capdevon-TestReverb branch June 15, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants