Make initial velocity influence newtornian particles#2470
Conversation
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information |
As long as initial velocity is 0,0,0 by default, then this shouldn't break anything and sounds like a good idea. |
|
This change seems reasonable. I think the screenshot pipeline failed (rather than the tests themselves). Worth just rerunning them and they may pass (not sure if the github UI allows that. Pushing an empty commit would do it) |
I've changed the newtonian influence to not ignore the initial velocity since it is a default property.
I need a second opinion on whether this is a good idea or now, but it might help making it more versatile.