Semgrep Rule Fix#2595
Closed
Akhil-gi wants to merge 2 commits into
Closed
Conversation
…ds-not-disabled-100-s0PY9atwi3 fix: semgrep-transformerfactory-dtds-not-disabled
codex128
requested changes
Feb 3, 2026
Contributor
codex128
left a comment
codex128
left a comment
There was a problem hiding this comment.
This change causes an exception when using XMLExporter:
SEVERE: Uncaught exception thrown in Thread[#44,jME3 Main,5,main]
java.lang.IllegalArgumentException: TransformerFactory does not recognise attribute 'accessExternalDTD'.
at java.xml/com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl.setAttribute(TransformerFactoryImpl.java:542)
at com.jme3.export.xml.XMLExporter.save(XMLExporter.java:100)
at com.jme3.export.xml.XMLExporter.save(XMLExporter.java:125)
at com.jme3.export.JmeExporter.save(JmeExporter.java:62)
at jme3test.export.TestIssue2068.simpleInitApp(TestIssue2068.java:104)
at com.jme3.app.SimpleApplication.initialize(SimpleApplication.java:246)
at com.jme3.system.lwjgl.LwjglAbstractDisplay.initInThread(LwjglAbstractDisplay.java:142)
at com.jme3.system.lwjgl.LwjglAbstractDisplay.run(LwjglAbstractDisplay.java:224)
Contributor
|
Closing because the PR is completely broken and the author does not seem interested in fixing it. Also in my mind, the use of AI to find the problem casts doubt on whether this is a real issue or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have used our AI-Guardian( https://ai-rem-demo.remediation.opsmx.net) product to identify and remediate a Semgrep rule violation
Pull Request — Semgrep Rule Fix
Rule ID: transformerfactory-dtds-not-disabled
Rule Message: DOCTYPE declarations are enabled for this TransformerFactory. This is vulnerable to XML external entity attacks. Disable this by setting the attributes "accessExternalDTD" and "accessExternalStylesheet" to "".
File Path: /tools/scanResult/unzipped-2878896019/jme3-plugins/src/xml/java/com/jme3/export/xml/XMLExporter.java
Line: 100