Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes support for 32-bit Windows and 32-bit macOS across the engine. Key changes include updating platform detection logic to throw exceptions for 32-bit systems, removing 32-bit enum constants from the Platform class, and cleaning up native library loading and build dependencies. Feedback suggests refactoring the platform detection logic in JmeSystemDelegate.java to reduce redundant bitness checks in the Windows and macOS blocks.
8Keep
changed the title
Member
|
Nice! Maybe we should drop MacOS Power PC too? |
8Keep
force-pushed
the
deprecate-32-bit
branch
2 times, most recently
from
2f8adc7 to
f1fc6cd
Compare
Contributor
Author
|
Done |
riccardobl
added
Refactoring and Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2588