Conversation
There was a problem hiding this comment.
Code Review
This pull request modernizes the Gradle build system by migrating to the Task Configuration Avoidance API, refactoring native library handling with the Sync task, and updating dependency management across several modules. Key feedback includes concerns about potential Javadoc build failures after removing lint suppression, the inclusion of unused variables and empty tasks, and recommendations to adhere to Gradle best practices regarding lazy evaluation and logging.
build.gradle
Outdated
| } | ||
|
|
||
| task run(dependsOn: ':jme3-examples:run') { | ||
| def runTask = tasks.register('run') { |
build.gradle
Outdated
| dependsOn cleanMergedJavadoc | ||
| } | ||
|
|
||
| tasks.register('mergedSource', Copy) |
build.gradle
Outdated
| zipFile: layout.buildDirectory.file("${nativesSnapshot}-natives.zip").get().asFile, | ||
| nativeDir: layout.buildDirectory.dir("native").get().asFile, |
There was a problem hiding this comment.
Calling .get() on a Provider (like layout.buildDirectory.file(...)) during the configuration phase is discouraged as it can break configuration caching and other lazy evaluation benefits. It is better to pass the Provider directly where possible, or only call .get() during the execution phase (e.g., inside a doFirst block or when resolving a value for an external tool like ant.get).
37931dd to
c3e8bf7
Compare
c3e8bf7 to
28e09c0
Compare
Cleaning up gradle build files to prepare for a new version of gradle.
Most of this is migrating to the lazy tasks apis.