Skip to content

Add autorun support for examples in gradle#2732

Merged
riccardobl merged 2 commits into
jMonkeyEngine:masterfrom
riccardobl:testrunner
May 1, 2026
Merged

Add autorun support for examples in gradle#2732
riccardobl merged 2 commits into
jMonkeyEngine:masterfrom
riccardobl:testrunner

Conversation

@riccardobl
Copy link
Copy Markdown
Member

No description provided.

@riccardobl riccardobl changed the title Add autorun support in TestChooser Add autorun support for examples in gradle May 1, 2026
gemini-code-assist[bot]

This comment was marked as outdated.

@riccardobl
Copy link
Copy Markdown
Member Author

@gemini-code-assist review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new runExamples Gradle task in the jme3-examples module, enabling users to run engine examples directly from the command line with an optional -Pexample property. Corresponding documentation has been added to the README.md. Feedback suggests improving the documentation's grammar and formatting for better readability. Additionally, it is recommended to refactor the runExamples task to be more idiomatic by moving the mainClass assignment to the configuration phase and using project.findProperty for safer access to the assertions property.

Comment thread README.md Outdated
Comment thread jme3-examples/build.gradle
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@riccardobl riccardobl merged commit 434047f into jMonkeyEngine:master May 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant