Add autorun support for examples in gradle#2732
Conversation
|
@gemini-code-assist review |
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
There was a problem hiding this comment.
Code Review
This pull request introduces a new runExamples Gradle task in the jme3-examples module, enabling users to run engine examples directly from the command line with an optional -Pexample property. Corresponding documentation has been added to the README.md. Feedback suggests improving the documentation's grammar and formatting for better readability. Additionally, it is recommended to refactor the runExamples task to be more idiomatic by moving the mainClass assignment to the configuration phase and using project.findProperty for safer access to the assertions property.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.