expand j3o scanner baseline#2734
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the J3OScanner to output unsafe reports to standard output and adds a note regarding the baseline's scope. It also significantly expands the j3o-baseline.txt file. Feedback highlights an incorrect package path for StructStd140BufferObject and notes that several added math classes are redundant as they do not implement the Savable interface.
| com.jme3.texture.TextureArray | ||
| com.jme3.texture.TextureCubeMap | ||
| com.jme3.ui.Picture | ||
| com.jme3.util.struct.StructStd140BufferObject |
There was a problem hiding this comment.
The package for StructStd140BufferObject is incorrect. In jMonkeyEngine, this class is located in com.jme3.shader.bufferobject, not com.jme3.util.struct. This will cause false positives when scanning J3O files that contain this class.
com.jme3.shader.bufferobject.StructStd140BufferObject
| com.jme3.math.Line | ||
| com.jme3.math.LineSegment | ||
| com.jme3.math.Matrix3f | ||
| com.jme3.math.Matrix4f | ||
| com.jme3.math.Plane | ||
| com.jme3.math.Quaternion | ||
| com.jme3.math.Ray | ||
| com.jme3.math.Rectangle | ||
| com.jme3.math.Ring | ||
| com.jme3.math.Spline | ||
| com.jme3.math.Transform | ||
| com.jme3.math.Triangle | ||
| com.jme3.math.Vector2f | ||
| com.jme3.math.Vector3f | ||
| com.jme3.math.Vector4f |
There was a problem hiding this comment.
Several added math classes (e.g., Line, LineSegment, Matrix3f, Matrix4f, Plane, Ray, Rectangle, Ring, Triangle, Vector4f) do not implement the com.jme3.export.Savable interface. Since the J3O class table only contains classes of Savable objects stored in the file, these entries are redundant and will never be matched by the scanner. Only Spline and Transform in this range are Savable.
1 participant
No description provided.