Skip to content

Commit 18ec740

Browse files
committed
Minor changes
1 parent 49680da commit 18ec740

3 files changed

Lines changed: 62 additions & 54 deletions

File tree

spml/src/main/resources/131-java-unit-testing.xml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
xsi:noNamespaceSchemaLocation="system-prompt.xsd"
44
id="131-java-unit-testing" version="1.0">
55
<metadata>
6-
<description>Java Unit testing guidelines</description>
7-
<globs>*.java</globs>
6+
<description></description>
7+
<globs></globs>
88
<always-apply>false</always-apply>
99
<tags>
1010
<tag>java</tag>
@@ -214,7 +214,7 @@ class UnstructuredTest {
214214
<rule-section number="4" id="use-descriptive-test-names">
215215
<rule-header>
216216
<rule-title>Use Descriptive Test Names</rule-title>
217-
<rule-subtitle>Write descriptive test method names or use @DisplayName</rule-subtitle>
217+
<rule-subtitle>Write descriptive test method names or use `@DisplayName`</rule-subtitle>
218218
</rule-header>
219219
<rule-description>
220220
Test names should clearly communicate the scenario being tested and the expected outcome. Use either descriptive method names (e.g., following the `should_ExpectedBehavior_when_StateUnderTest` pattern) or JUnit 5's `@DisplayName` annotation for more natural language descriptions. This makes test reports easier to understand.
@@ -487,10 +487,10 @@ class UserServiceTestBad {
487487
DatabaseConnection connection = new DatabaseConnection("localhost", 5432);
488488
UserRepository userRepository = new PostgresUserRepository(connection);
489489
UserService userService = new UserService(userRepository);
490-
490+
491491
// This test depends on database availability and state
492492
Optional<User> user = userService.findUserById("123");
493-
493+
494494
// Test is slow, brittle, and doesn't isolate the unit under test
495495
assertThat(user).isPresent();
496496
}
@@ -598,7 +598,7 @@ public class CalculatorTest {
598598
void add_zeroAndNumber_returnsNumber() {
599599
assertThat(calculator.add(0, 5)).isEqualTo(5);
600600
}
601-
601+
602602
@Test
603603
void add_numberAndZero_returnsNumber() {
604604
assertThat(calculator.add(5, 0)).isEqualTo(5);
@@ -608,7 +608,7 @@ public class CalculatorTest {
608608
void add_positiveAndNegative_returnsCorrectSum() {
609609
assertThat(calculator.add(5, -4)).isEqualTo(1);
610610
}
611-
611+
612612
@Test
613613
void add_nearMaxInteger_returnsCorrectSum() {
614614
assertThat(calculator.add(Integer.MAX_VALUE - 1, 1)).isEqualTo(Integer.MAX_VALUE);
@@ -630,7 +630,7 @@ public class CalculatorTest {
630630
.isInstanceOf(ArithmeticException.class)
631631
.hasMessageContaining("overflow");
632632
}
633-
633+
634634
@Test
635635
void add_integerUnderflow_throwsArithmeticException() {
636636
assertThatThrownBy(() -> calculator.add(Integer.MIN_VALUE, -1))
@@ -738,7 +738,7 @@ public class OrderProcessorTest {
738738
assertThatThrownBy(() -> processor.addItem(null))
739739
.isInstanceOf(IllegalArgumentException.class);
740740
}
741-
741+
742742
// Thorough: Testing another edge case (adding empty string).
743743
@Test
744744
void addItem_emptyItem_throwsIllegalArgumentException() {
@@ -824,12 +824,12 @@ public class UserValidation {
824824
// C - Conformance (simplified regex for demonstration)
825825
return email.matches("^[\\w-\\.]+@([\\w-]+\\.)+[\\w-]{2,4}$");
826826
}
827-
827+
828828
// E - Existence
829829
public boolean processUsername(String username) {
830830
if (Objects.isNull(username) || username.trim().isEmpty()) {
831831
// Checks for existence (non-null, non-empty)
832-
return false;
832+
return false;
833833
}
834834
// process username
835835
return true;
@@ -855,7 +855,7 @@ public class UserValidationTest {
855855
void isAgeValid_ageAtUpperBound_returnsTrue() {
856856
assertThat(validator.isAgeValid(120)).isTrue();
857857
}
858-
858+
859859
@Test
860860
void isAgeValid_ageWithinBounds_returnsTrue() {
861861
assertThat(validator.isAgeValid(35)).isTrue();
@@ -883,7 +883,7 @@ public class UserValidationTest {
883883
void isValidEmailFormat_invalidEmails_returnsFalse(String email) {
884884
assertThat(validator.isValidEmailFormat(email)).isFalse();
885885
}
886-
886+
887887
@Test
888888
void isValidEmailFormat_nullEmail_returnsFalse() {
889889
assertThat(validator.isValidEmailFormat(null)).isFalse();
@@ -899,7 +899,7 @@ public class UserValidationTest {
899899
void processUsername_nullUsername_returnsFalse() {
900900
assertThat(validator.processUsername(null)).isFalse();
901901
}
902-
902+
903903
@Test
904904
void processUsername_emptyUsername_returnsFalse() {
905905
assertThat(validator.processUsername("")).isFalse();
@@ -924,7 +924,7 @@ public class UserValidationPoorTest {
924924
assertThat(validator.isAgeValid(25)).isTrue(); // Only one value tested.
925925
// Min, max, below min, above max are not tested.
926926
}
927-
927+
928928
@Test
929929
void isValidEmailFormat_typicalEmail_returnsTrue() {
930930
assertThat(validator.isValidEmailFormat("test@example.com")).isTrue(); // No invalid formats, no nulls.

spml/src/test/java/info/jab/xml/CursorRuleGeneratorTest.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,15 @@ void should_produceConsistentStructure_when_processingDifferentXmlTypes() throws
150150
String bestPracticesResult = generator.generate("110-java-maven-best-practices.xml", "unified-generator.xsl");
151151
String documentationResult = generator.generate("112-java-maven-documentation.xml", "unified-generator.xsl");
152152
String checklistGuideResult = generator.generate("100-java-checklist-guide.xml", "unified-generator.xsl");
153+
String objectOrientedDesignResult = generator.generate("121-java-object-oriented-design.xml", "unified-generator.xsl");
154+
String typeDesignResult = generator.generate("122-java-type-design.xml", "unified-generator.xsl");
155+
String generalGuidelinesResult = generator.generate("123-java-general-guidelines.xml", "unified-generator.xsl");
156+
String secureCodingResult = generator.generate("124-java-secure-coding.xml", "unified-generator.xsl");
157+
String concurrencyResult = generator.generate("125-java-concurrency.xml", "unified-generator.xsl");
158+
String loggingResult = generator.generate("126-java-logging.xml", "unified-generator.xsl");
159+
String unitTestingResult = generator.generate("131-java-unit-testing.xml", "unified-generator.xsl");
160+
String refactoringWithModernFeaturesResult = generator.generate("141-java-refactoring-with-modern-features.xml", "unified-generator.xsl");
161+
String dataOrientedProgrammingResult = generator.generate("143-java-data-oriented-programming.xml", "unified-generator.xsl");
153162

154163
// Then - All should have consistent frontmatter and structure
155164
assertThat(bestPracticesResult)
@@ -171,6 +180,15 @@ void should_produceConsistentStructure_when_processingDifferentXmlTypes() throws
171180
saveGeneratedContentToTarget(bestPracticesResult, "unified-best-practices.mdc");
172181
saveGeneratedContentToTarget(documentationResult, "unified-documentation.mdc");
173182
saveGeneratedContentToTarget(checklistGuideResult, "unified-checklist-guide.mdc");
183+
saveGeneratedContentToTarget(objectOrientedDesignResult, "unified-object-oriented-design.mdc");
184+
saveGeneratedContentToTarget(typeDesignResult, "unified-type-design.mdc");
185+
saveGeneratedContentToTarget(generalGuidelinesResult, "unified-general-guidelines.mdc");
186+
saveGeneratedContentToTarget(secureCodingResult, "unified-secure-coding.mdc");
187+
saveGeneratedContentToTarget(concurrencyResult, "unified-concurrency.mdc");
188+
saveGeneratedContentToTarget(loggingResult, "unified-logging.mdc");
189+
saveGeneratedContentToTarget(unitTestingResult, "unified-unit-testing.mdc");
190+
saveGeneratedContentToTarget(refactoringWithModernFeaturesResult, "unified-refactoring-with-modern-features.mdc");
191+
saveGeneratedContentToTarget(dataOrientedProgrammingResult, "unified-data-oriented-programming.mdc");
174192
}
175193

176194
@Test

0 commit comments

Comments
 (0)