Skip to content

Commit cd34e16

Browse files
jabrenajabrena
committed
feat(skills): Improve structure of any SKILL.md with a defined Workflow
1 parent cf8966d commit cd34e16

28 files changed

Lines changed: 534 additions & 0 deletions

File tree

‎skills-generator/src/main/resources/skill-indexes/121-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,25 @@ Review and improve Java code using comprehensive object-oriented design guidelin
4949
</trigger-list>
5050
</triggers>
5151

52+
<steps>
53+
<step number="1">
54+
<step-title>Compile project before OOD changes</step-title>
55+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
56+
</step>
57+
<step number="2">
58+
<step-title>Read OOD reference and assess code</step-title>
59+
<step-content>Read `references/121-java-object-oriented-design.md` and identify applicable SOLID/OOP/code-smell improvements.</step-content>
60+
</step>
61+
<step number="3">
62+
<step-title>Apply focused refactorings</step-title>
63+
<step-content>Implement the selected object-oriented design improvements while preserving behavior.</step-content>
64+
</step>
65+
<step number="4">
66+
<step-title>Verify with full build</step-title>
67+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
68+
</step>
69+
</steps>
70+
5271
<references>
5372
<reference-list>
5473
<reference>references/121-java-object-oriented-design.md</reference>

‎skills-generator/src/main/resources/skill-indexes/122-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,25 @@ Review and improve Java code using comprehensive type design principles that app
5252
</trigger-list>
5353
</triggers>
5454

55+
<steps>
56+
<step number="1">
57+
<step-title>Compile project before type-design changes</step-title>
58+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
59+
</step>
60+
<step number="2">
61+
<step-title>Read type-design reference and inspect code</step-title>
62+
<step-content>Read `references/122-java-type-design.md` and identify type hierarchy, naming, and value-object improvements.</step-content>
63+
</step>
64+
<step number="3">
65+
<step-title>Apply type-design refactorings</step-title>
66+
<step-content>Implement selected type-safety and readability improvements based on applicable patterns.</step-content>
67+
</step>
68+
<step number="4">
69+
<step-title>Verify with full build</step-title>
70+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
71+
</step>
72+
</steps>
73+
5574
<references>
5675
<reference-list>
5776
<reference>references/122-java-type-design.md</reference>

‎skills-generator/src/main/resources/skill-indexes/123-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,25 @@ Identify and apply robust Java exception handling practices to improve error cla
5353
</trigger-list>
5454
</triggers>
5555

56+
<steps>
57+
<step number="1">
58+
<step-title>Compile project before exception-handling changes</step-title>
59+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
60+
</step>
61+
<step number="2">
62+
<step-title>Read exception-handling reference</step-title>
63+
<step-content>Read `references/123-java-exception-handling.md` and identify applicable failure-handling and observability improvements.</step-content>
64+
</step>
65+
<step number="3">
66+
<step-title>Apply exception-handling improvements</step-title>
67+
<step-content>Refactor to specific exceptions, safe resource handling, error translation, and consistent logging patterns.</step-content>
68+
</step>
69+
<step number="4">
70+
<step-title>Verify with full build</step-title>
71+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
72+
</step>
73+
</steps>
74+
5675
<references>
5776
<reference-list>
5877
<reference>references/123-java-exception-handling.md</reference>

‎skills-generator/src/main/resources/skill-indexes/124-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,25 @@ Identify and apply Java secure coding practices to reduce vulnerabilities, prote
4343
</trigger-list>
4444
</triggers>
4545

46+
<steps>
47+
<step number="1">
48+
<step-title>Compile project before secure-coding changes</step-title>
49+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
50+
</step>
51+
<step number="2">
52+
<step-title>Read secure-coding reference and assess risks</step-title>
53+
<step-content>Read `references/124-java-secure-coding.md` and identify applicable vulnerabilities and hardening opportunities.</step-content>
54+
</step>
55+
<step number="3">
56+
<step-title>Apply secure-coding improvements</step-title>
57+
<step-content>Implement selected protections for input validation, crypto, secrets, deserialization, and output encoding.</step-content>
58+
</step>
59+
<step number="4">
60+
<step-title>Verify with full build</step-title>
61+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
62+
</step>
63+
</steps>
64+
4665
<references>
4766
<reference-list>
4867
<reference>references/124-java-secure-coding.md</reference>

‎skills-generator/src/main/resources/skill-indexes/125-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,25 @@ Identify and apply Java concurrency best practices to improve thread safety, sca
5050
</trigger-list>
5151
</triggers>
5252

53+
<steps>
54+
<step number="1">
55+
<step-title>Compile project before concurrency changes</step-title>
56+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
57+
</step>
58+
<step number="2">
59+
<step-title>Read concurrency reference and analyze hotspots</step-title>
60+
<step-content>Read `references/125-java-concurrency.md` and identify thread-safety, coordination, and throughput issues to address.</step-content>
61+
</step>
62+
<step number="3">
63+
<step-title>Apply concurrency improvements</step-title>
64+
<step-content>Implement suitable concurrency patterns, cancellation discipline, and fit-for-purpose primitives.</step-content>
65+
</step>
66+
<step number="4">
67+
<step-title>Verify with full build</step-title>
68+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
69+
</step>
70+
</steps>
71+
5372
<references>
5473
<reference-list>
5574
<reference>references/125-java-concurrency.md</reference>

‎skills-generator/src/main/resources/skill-indexes/128-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,25 @@ Review and improve Java code using comprehensive generics best practices that en
4949
</trigger-list>
5050
</triggers>
5151

52+
<steps>
53+
<step number="1">
54+
<step-title>Compile project before generics changes</step-title>
55+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
56+
</step>
57+
<step number="2">
58+
<step-title>Read generics reference and assess type safety</step-title>
59+
<step-content>Read `references/128-java-generics.md` and identify raw types, unsafe casts, wildcard misuse, and API variance opportunities.</step-content>
60+
</step>
61+
<step number="3">
62+
<step-title>Apply generics refactorings</step-title>
63+
<step-content>Implement selected generic type and API improvements while preserving behavior.</step-content>
64+
</step>
65+
<step number="4">
66+
<step-title>Verify with full build</step-title>
67+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
68+
</step>
69+
</steps>
70+
5271
<references>
5372
<reference-list>
5473
<reference>references/128-java-generics.md</reference>

‎skills-generator/src/main/resources/skill-indexes/130-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,25 @@ Apply proven testing strategies (RIGHT-BICEP, A-TRIP, CORRECT) to design and ver
4040
</trigger-list>
4141
</triggers>
4242

43+
<steps>
44+
<step number="1">
45+
<step-title>Compile project before test-strategy changes</step-title>
46+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
47+
</step>
48+
<step number="2">
49+
<step-title>Read testing-strategies reference</step-title>
50+
<step-content>Read `references/130-java-testing-strategies.md` and map current tests to RIGHT-BICEP, A-TRIP, and CORRECT gaps.</step-content>
51+
</step>
52+
<step number="3">
53+
<step-title>Apply strategy-driven test improvements</step-title>
54+
<step-content>Improve or add tests to cover missing boundaries, quality characteristics, and verification depth.</step-content>
55+
</step>
56+
<step number="4">
57+
<step-title>Verify with full build</step-title>
58+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
59+
</step>
60+
</steps>
61+
4362
<references>
4463
<reference-list>
4564
<reference>references/130-java-testing-strategies.md</reference>

‎skills-generator/src/main/resources/skill-indexes/131-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,25 @@ Review and improve Java unit tests using modern JUnit 5, AssertJ, and Mockito be
4747
</trigger-list>
4848
</triggers>
4949

50+
<steps>
51+
<step number="1">
52+
<step-title>Compile project before unit-test changes</step-title>
53+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
54+
</step>
55+
<step number="2">
56+
<step-title>Read unit-testing reference and evaluate coverage</step-title>
57+
<step-content>Read `references/131-java-testing-unit-testing.md` and identify modernization and quality gaps in current tests.</step-content>
58+
</step>
59+
<step number="3">
60+
<step-title>Apply unit-testing best practices</step-title>
61+
<step-content>Implement or refactor tests using JUnit 5, AssertJ, Mockito, parameterization, and stronger boundary checks.</step-content>
62+
</step>
63+
<step number="4">
64+
<step-title>Verify with full build</step-title>
65+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
66+
</step>
67+
</steps>
68+
5069
<references>
5170
<reference-list>
5271
<reference>references/131-java-testing-unit-testing.md</reference>

‎skills-generator/src/main/resources/skill-indexes/132-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,25 @@ Set up robust integration-test infrastructure for Java services using WireMock t
4747
</trigger-list>
4848
</triggers>
4949

50+
<steps>
51+
<step number="1">
52+
<step-title>Compile project before integration-test changes</step-title>
53+
<step-content>Run `./mvnw compile` or `mvn compile` and stop immediately if compilation fails.</step-content>
54+
</step>
55+
<step number="2">
56+
<step-title>Read integration-testing reference and detect topology</step-title>
57+
<step-content>Read `references/132-java-testing-integration-testing.md` and detect HTTP client and external dependency integration points.</step-content>
58+
</step>
59+
<step number="3">
60+
<step-title>Set up resilient integration-test infrastructure</step-title>
61+
<step-content>Implement BaseIntegrationTest, WireMock mappings/stubs, per-test isolation, and verification patterns.</step-content>
62+
</step>
63+
<step number="4">
64+
<step-title>Verify with full build</step-title>
65+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
66+
</step>
67+
</steps>
68+
5069
<references>
5170
<reference-list>
5271
<reference>references/132-java-testing-integration-testing.md</reference>

‎skills-generator/src/main/resources/skill-indexes/133-skill.xml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,25 @@ Implement acceptance tests from Gherkin feature files. Given a .feature file in
4747
</trigger-list>
4848
</triggers>
4949

50+
<steps>
51+
<step number="1">
52+
<step-title>Validate preconditions and compile project</step-title>
53+
<step-content>Confirm `.feature` file is in context and framework scope is valid, then run `./mvnw compile` or `mvn compile`; stop if any precondition fails.</step-content>
54+
</step>
55+
<step number="2">
56+
<step-title>Read acceptance-testing reference and parse scenarios</step-title>
57+
<step-content>Read `references/133-java-testing-acceptance-tests.md` and extract `@acceptance` scenarios for happy-path implementation.</step-content>
58+
</step>
59+
<step number="3">
60+
<step-title>Implement acceptance test infrastructure and scenarios</step-title>
61+
<step-content>Create or update base test infrastructure (RestAssured, Testcontainers, WireMock) and implement one happy-path test per accepted scenario.</step-content>
62+
</step>
63+
<step number="4">
64+
<step-title>Verify with full build</step-title>
65+
<step-content>Run `./mvnw clean verify` or `mvn clean verify` after applying improvements.</step-content>
66+
</step>
67+
</steps>
68+
5069
<references>
5170
<reference-list>
5271
<reference>references/133-java-testing-acceptance-tests.md</reference>

0 commit comments

Comments
 (0)