Skip to content

Commit db42ca3

Browse files
committed
Add comments indicating methods required for ambiguity resolution.
1 parent 229217b commit db42ca3

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/dataview.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ function Base.isassigned(view::EdgeDataView, key::Pair)
6666
return isassigned(view, to_graph_index(view.graph, key))
6767
end
6868

69-
Base.getindex(view::VertexOrEdgeDataView{K}, key::K) where {K} = _getindex(view, key)
7069
Base.getindex(view::VertexOrEdgeDataView, key) = _getindex(view, key)
70+
# For method ambiguity:
71+
Base.getindex(view::VertexOrEdgeDataView{K}, key::K) where {K} = _getindex(view, key)
7172

7273
function _getindex(view::VertexDataView, key)
7374
isassigned(view, key) || throw(IndexError("VertexDataView does not contain index $key"))
@@ -133,7 +134,9 @@ end
133134
Base.keys(dvs::SubDataView) = dvs.inds
134135

135136
Base.getindex(view::SubDataView, key) = getindex_dataview(view, key)
137+
# For method ambiguity:
136138
Base.getindex(view::SubDataView{K}, key::K) where {K} = getindex_dataview(view, key)
139+
137140
function getindex_dataview(dvs::SubDataView, key)
138141
isassigned(dvs, key) || throw(IndexError("Dictionary does not contain index: $key"))
139142
return dvs.view[key]

0 commit comments

Comments
 (0)