Add Settings view colours

Author: jack5github

CHANGELOG.md

@@ -12,7 +12,7 @@
 - Elm, Java, Lua, SourcePawn and TypeScript support
 - Error Lens extension support, adding error, warning and info colours
 - Inactive title bar colour
-- List, input, checkbox and dropdown background, foreground and placeholder colours
+- List, input, checkbox and dropdown background, foreground and placeholder colours (includes Settings view)
 - Markdown preview colours for preformatted text and blockquotes
 - Overview ruler colours (seen under vertical scrollbar)
 - Python: Class semantic colours `variable.language.special.self`, `variable.parameter.function.language.special.cls` and `variable.language.special.cls`

docs/colours.md

@@ -51,6 +51,21 @@ The background colour of inputs looks good as the Command Palette background col
 > - `dropdown.background`
 > - `input.background`
 
+###### Settings
+
+The above background colours do not work well in the Settings view, as they blend in too much with the editor area. Rather than using a 3:2 mix of the editor area colour and the active tab colour, these use a 1:2 mix, ensuring that they stand out without looking polarising.
+
+> - `settings.checkboxBackground`
+> - `settings.dropdownBackground`
+> - `settings.numberInputBackground`
+> - `settings.textInputBackground`
+
+However, the highlight colours too blend in with the above backgrounds, so they must be changed as well. Rather than trying to find more appropriate bright colours, I have chosen to use black alphas, picking the right value for `settings.focusedRowBackground` first (so preformatted text is still legible when an option is focused) and the others second (any lower and they become too hard to see).
+
+> - `settings.rowHoverBackground`
+> - `settings.settingsHeaderHoverForeground`
+> - `settings.focusedRowBackground`
+
 ##### Foregrounds
 
 The foreground colour of inputs can be the same as other text in the IDE, and placeholder text can be the same colour as comments and ignored text.

themes/Oblique Dark Orange-color-theme.json

@@ -12,6 +12,13 @@
 		"list.hoverBackground": "#ffffff0c",
 		"dropdown.background": "#121e1e",
 		"input.background": "#121e1e",
+		"settings.checkboxBackground": "#152121",
+		"settings.dropdownBackground": "#152121",
+		"settings.numberInputBackground": "#152121",
+		"settings.textInputBackground": "#152121",
+		"settings.rowHoverBackground": "#0000000e",
+		"settings.settingsHeaderHoverForeground": "#0000000e",
+		"settings.focusedRowBackground": "#00000022",
 		"dropdown.foreground": "#acc6c6",
 		"input.foreground": "#acc6c6",
 		"input.placeholderForeground": "#536060",